From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EE2AC1FF15C for ; Wed, 19 Feb 2025 11:17:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CE0E01D43E; Wed, 19 Feb 2025 11:17:29 +0100 (CET) Message-ID: <6fddea71-8e9c-4e50-8175-72e24986e214@proxmox.com> Date: Wed, 19 Feb 2025 11:17:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Maximiliano Sandoval References: <20250219095848.129788-1-m.sandoval@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20250219095848.129788-1-m.sandoval@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.295 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [btrfsplugin.pm] URI_NOVOWEL 0.5 URI hostname has long non-vowel sequence Subject: Re: [pve-devel] [PATCH storage v3 1/4] btrfs: add helper to iterate over snapshots of a subvolume X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 19.02.25 um 10:58 schrieb Maximiliano Sandoval: > In this context a subvolume means a BTRFS subvolume. > `$volume\@$snap_name` would be for example > `btrfs_volume/images/102/vm-102-disk-0@snap_name`. > > Signed-off-by: Maximiliano Sandoval > --- > > Differences from v2: > - Split into multiple commits > - Simplify patch > - Use only the snapshot name in the callback of the helper > > Differences from v1: > - Add a helper to run callback on each snapshot. > > src/PVE/Storage/BTRFSPlugin.pm | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/src/PVE/Storage/BTRFSPlugin.pm b/src/PVE/Storage/BTRFSPlugin.pm > index cadd9d1..43f797a 100644 > --- a/src/PVE/Storage/BTRFSPlugin.pm > +++ b/src/PVE/Storage/BTRFSPlugin.pm > @@ -419,6 +419,20 @@ my sub foreach_subvol : prototype($$) { > }) > } > > +# Calls `$code->($volume, $snap_name)` for each snapshot of the BTRFS subvolume. > +my sub foreach_snapshot_of_subvol : prototype($$) { > + my ($subvol, $code) = @_; > + > + my $basename = basename($subvol); > + my $dir = dirname($subvol); > + foreach_subvol($dir, sub { We're getting there, but: This helper still is named incorrectly. I'd like to have the helper and the regex be named correctly (not your fault, but it just gets more confusing if there are more users). You can change the helper to only operate on a given subvolume, because that is the only use case we have. I.e. merge your wrapper and the original helper. I'd also name it foreach_snapshot_of_subvolume() to better differentiate it from the 'subvol' format, and path_is_subvolume() already uses the word 'subvolume'. > + my ($volume, $name, $snap) = @_; > + return if $name ne $basename; > + return if !defined $snap; > + $code->($snap); > + }); > +} > + > sub free_image { > my ($class, $storeid, $scfg, $volname, $isBase, $_format) = @_; > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel