Re: [pve-devel] [PATCH qemu-server 02/10] add memory parser

["DERUMIER, Alexandre" <Alexandre.DERUMIER@groupe-cyllene.com>]

Hi Fiona,


I'm beginning to rework the patch serie 

If it's ok for you, I'll split it in differents patch series, 1 to add
the parser, 1 for maxmem and 1 for virtio.

About this comment:

Le vendredi 16 décembre 2022 à 14:38 +0100, Fiona Ebner a écrit :
> > diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm
> > index e91f906..9115d50 100644
> > --- a/PVE/QemuServer/Helpers.pm
> > +++ b/PVE/QemuServer/Helpers.pm
> > @@ -143,8 +143,7 @@ sub version_cmp {
> >   }
> >   
> >   sub config_aware_timeout {
> > -    my ($config, $is_suspended) = @_;
> > -    my $memory = $config->{memory};
> > +    my ($config, $memory, $is_suspended) = @_;
> 
> Why do you add this? Also, when you adapt the callers, you only pass
> in
> $config->{memory} which is already part of $config.

When I try to 

use PVE::QemuServer::Memory qw(get_current_memory);

in the Helpers.pm, to parse the $conf->{memory},

I'm getting errors in tests:

# error does not match expected error: 'Undefined subroutine
&PVE::QemuServer::windows_version called at ../PVE/QemuServer.pm line
3562.

That's why I'm parsing the memory in QemuServer and send it as param
config_aware_timeout.


Do you known a better way to do it ?