From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 59D0A60D3B for <pve-devel@lists.proxmox.com>; Tue, 15 Dec 2020 16:20:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 52AB414A36 for <pve-devel@lists.proxmox.com>; Tue, 15 Dec 2020 16:20:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 35F1714A2A for <pve-devel@lists.proxmox.com>; Tue, 15 Dec 2020 16:20:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 064A3451C1 for <pve-devel@lists.proxmox.com>; Tue, 15 Dec 2020 16:20:57 +0100 (CET) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com> References: <20201201120702.3869-1-f.ebner@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <6eddab54-aae2-b7a4-6058-cdcd20d81f45@proxmox.com> Date: Tue, 15 Dec 2020 16:20:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 MIME-Version: 1.0 In-Reply-To: <20201201120702.3869-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.066 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [shared.pm, qmmock.pm, qemumigrate.pm, migrate.pm, qemumigratemock.pm] Subject: [pve-devel] applied-series: [PATCH-SERIES v3] migration tests X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 15 Dec 2020 15:20:58 -0000 On 01.12.20 13:06, Fabian Ebner wrote: > Refactor some code and create a test enviroment for migration. See the = last > patch for a description of the latter. >=20 > The first two patches depend on libpve-guest-common-perl >=3D3.1-3 >=20 > Changes from v2: > * drop already applied patch introducing move_config_to_node helper= > * rebase on current master and verify tests still behave the same > way (they did, but it's not surprising as QemuMigrate.pm didn't > change much since v2 was sent). > * add a patch to sort volumes migrated with storage_migrate and ada= pt > affected test >=20 >=20 > container: >=20 > Fabian Ebner (1): > use new move_config_to_node method >=20 > src/PVE/LXC/Migrate.pm | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) >=20 >=20 > qemu-server: >=20 > Fabian Ebner (4): > use new move_config_to_node method > migration: factor out starting remote tunnel > migration: sort volumes migrated with storage_migrate > create test environment for migration >=20 > PVE/QemuMigrate.pm | 130 +- > test/Makefile | 5 +- > test/MigrationTest/QemuMigrateMock.pm | 319 +++++ > test/MigrationTest/QmMock.pm | 142 +++ > test/MigrationTest/Shared.pm | 170 +++ > test/run_qemu_migrate_tests.pl | 1594 +++++++++++++++++++++++++= > 6 files changed, 2295 insertions(+), 65 deletions(-) > create mode 100644 test/MigrationTest/QemuMigrateMock.pm > create mode 100644 test/MigrationTest/QmMock.pm > create mode 100644 test/MigrationTest/Shared.pm > create mode 100755 test/run_qemu_migrate_tests.pl >=20 applied series, thanks! The tests for qemu add ~ 36s of build time, which is rather much for that= package. Can you look into this, maybe we can move the tests to single .json file = snippets and do them in parallel through the make buildsystem.