From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D62271FF13A for ; Wed, 13 May 2026 17:14:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CA28B150BD; Wed, 13 May 2026 17:14:52 +0200 (CEST) Message-ID: <6e5aaa63-60ce-4d8c-806d-b13f68327e8e@proxmox.com> Date: Wed, 13 May 2026 17:14:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server v3 3/3] fix #7119: qm cleanup: wait for process exiting for up to 30 seconds To: Dominik Csapak , pve-devel@lists.proxmox.com References: <20260226140752.1792378-1-d.csapak@proxmox.com> <20260226140752.1792378-4-d.csapak@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260226140752.1792378-4-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778685277913 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KYNXZQXSHNVBACXPQGS5VW56R6BJSGTE X-Message-ID-Hash: KYNXZQXSHNVBACXPQGS5VW56R6BJSGTE X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 26.02.26 um 3:08 PM schrieb Dominik Csapak: > When qmeventd detects a vm exiting, it starts 'qm cleanup'. > > Since the vm process exits is sometimes not instant, wait up to 30 > seconds here to start the cleanup process instead of immediately > aborting if the pid still exits. This prevented executing the hookscript > on the 'post-stop' phase when either > * the cleanup mechanism is still the old one > * the guest was powered down from inside, not via the API > > This can be reproduced by e.g. passing through a usb device, which > delays the qemu process exit for a few seconds (for most devices). > > Signed-off-by: Dominik Csapak > --- > src/PVE/CLI/qm.pm | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/CLI/qm.pm b/src/PVE/CLI/qm.pm > index 6aff5b7a..ee3ccedd 100755 > --- a/src/PVE/CLI/qm.pm > +++ b/src/PVE/CLI/qm.pm > @@ -1101,7 +1101,7 @@ __PACKAGE__->register_method({ > 60, > sub { > my $conf = PVE::QemuConfig->load_config($vmid); > - my $pid = PVE::QemuServer::check_running($vmid); > + my $pid = PVE::QemuServer::Helpers::vm_running_locally($vmid); > > # With a stop mode backup, we might run here into a running vm with a backup > # lock, but this already did the cleanup and is an expected state, so abort > @@ -1109,7 +1109,19 @@ __PACKAGE__->register_method({ > die "skipping cleanup - 'backup' lock is present and vm is running again\n" > if $pid && $clean && $conf->{lock} && $conf->{lock} eq 'backup'; > > - die "vm still running\n" if $pid; > + # wait for some time until the QEMU process exits after the QMP > + # 'SHUTDOWN' event, since this might not be instant > + my $timeout = 30; > + my $starttime = time(); > + warn "QEMU process $pid for VM $vmid still running (or newly started)\n" > + if $pid; Should we maybe warn once after 10? seconds rather than instantly? Not sure if we should warn at all if it's expected to take a while in some cases. If we time out, we still get the error below. > + > + while ($pid && (time() - $starttime) < $timeout) { > + sleep(1); > + $pid = PVE::QemuServer::check_running($vmid); Should also use the non-deprecated helper. > + } > + > + die "vm still running after timeout - aborting cleanup\n" if $pid; > > # Rollback already does cleanup when preparing and afterwards temporarily drops the > # lock on the configuration file to rollback the volumes. Deactivating volumes here