From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 947631FF170 for ; Thu, 7 Aug 2025 14:02:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0E91B1D29B; Thu, 7 Aug 2025 14:04:27 +0200 (CEST) Message-ID: <6e3ffc1e-ccfc-4ec6-93f7-03bef79c8b78@proxmox.com> Date: Thu, 7 Aug 2025 14:04:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Fiona Ebner References: <20250807104832.51784-1-f.ebner@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20250807104832.51784-1-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754568240407 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server] snapshot create/delete: die early for snapshot-as-volume-chain for pre-10.0 machine version X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Could reproduce the problem described in [0], patch works as advertised, so consider this Tested-by: Hannes Laimer On 07.08.25 12:48, Fiona Ebner wrote: > As reported in the community forum [0], a running VM with pre-10.0 > machine version using a storage with snapshot-as-volume-chain will run > into issues when creating a snapshot. Similarly deleting the snapshot > of such a VM would fail. Having '-blockdev' is a hard requirement for > the implementation of the snapshot-as-volume-chain feature for running > VMs, so die and suggest upgrading the machine version. > > [0]: https://forum.proxmox.com/threads/lvm-thick-with-iscsi-pve-9-0-3.169319/ > > Signed-off-by: Fiona Ebner > --- > src/PVE/QemuServer.pm | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm > index d42e2115..e30b27cb 100644 > --- a/src/PVE/QemuServer.pm > +++ b/src/PVE/QemuServer.pm > @@ -4447,12 +4447,17 @@ sub qemu_volume_snapshot { > print "internal qemu snapshot\n"; > mon_cmd($vmid, 'blockdev-snapshot-internal-sync', device => $deviceid, name => $snap); > } elsif ($do_snapshots_type eq 'external') { > + my $machine_version = PVE::QemuServer::Machine::get_current_qemu_machine($vmid); > + if (!PVE::QemuServer::Machine::is_machine_version_at_least($machine_version, 10, 0)) { > + die "storage for '$volid' is configured for snapshots as a volume chain - this requires" > + . " QEMU machine version >= 10.0. See" > + . " https://pve.proxmox.com/wiki/QEMU_Machine_Version_Upgrade\n"; > + } > my $storeid = (PVE::Storage::parse_volume_id($volid))[0]; > my $scfg = PVE::Storage::storage_config($storecfg, $storeid); > print "external qemu snapshot\n"; > my $snapshots = PVE::Storage::volume_snapshot_info($storecfg, $volid); > my $parent_snap = $snapshots->{'current'}->{parent}; > - my $machine_version = PVE::QemuServer::Machine::get_current_qemu_machine($vmid); > PVE::QemuServer::Blockdev::blockdev_external_snapshot( > $storecfg, $vmid, $machine_version, $deviceid, $drive, $snap, $parent_snap, > ); > @@ -4489,6 +4494,13 @@ sub qemu_volume_snapshot_delete { > name => $snap, > ); > } elsif ($do_snapshots_type eq 'external') { > + my $machine_version = PVE::QemuServer::Machine::get_current_qemu_machine($vmid); > + if (!PVE::QemuServer::Machine::is_machine_version_at_least($machine_version, 10, 0)) { > + die "storage for '$volid' is configured for snapshots as a volume chain - this requires" > + . " QEMU machine version >= 10.0. See" > + . " https://pve.proxmox.com/wiki/QEMU_Machine_Version_Upgrade\n"; > + } > + > print "delete qemu external snapshot\n"; > > my $path = PVE::Storage::path($storecfg, $volid); > @@ -4499,7 +4511,6 @@ sub qemu_volume_snapshot_delete { > > my $parentsnap = $snapshots->{$snap}->{parent}; > my $childsnap = $snapshots->{$snap}->{child}; > - my $machine_version = PVE::QemuServer::Machine::get_current_qemu_machine($vmid); > > # if we delete the first snasphot, we commit because the first snapshot original base image, it should be big. > # improve-me: if firstsnap > child : commit, if firstsnap < child do a stream. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel