From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A7D4194472 for <pve-devel@lists.proxmox.com>; Thu, 23 Feb 2023 16:36:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8ACCB26B9B for <pve-devel@lists.proxmox.com>; Thu, 23 Feb 2023 16:36:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Thu, 23 Feb 2023 16:36:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CF9B9482B8 for <pve-devel@lists.proxmox.com>; Thu, 23 Feb 2023 16:36:36 +0100 (CET) Message-ID: <6dcec81f-dbb0-3728-0599-ae52d38006b9@proxmox.com> Date: Thu, 23 Feb 2023 16:36:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:110.0) Gecko/20100101 Thunderbird/110.0 Content-Language: de-AT, en-GB To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Christoph Heiss <c.heiss@proxmox.com> References: <20230223141805.446192-1-c.heiss@proxmox.com> <20230223141805.446192-2-c.heiss@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20230223141805.446192-2-c.heiss@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] applied: [PATCH v2 qemu-server 1/3] vzdump: Add VM QGA option to skip fs-freeze/-thaw on backup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 23 Feb 2023 15:36:37 -0000 Am 23/02/2023 um 15:18 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss <c.heiss@proxmox.com> > --- > Changes v1 -> v2: > * Rename option from 'fsfreeze_thaw' to 'freeze-fs-on-backup' > * Adapt option description as suggested > * Fix option check in qga_fs_freeze() > > PVE/QemuServer.pm | 8 +++++++- > PVE/VZDump/QemuServer.pm | 6 ++++++ > 2 files changed, 13 insertions(+), 1 deletion(-) > > applied, thanks! FWIW, I forgot to write in my review of v1 that having the disabled-in-config check done before the is-qga-running one would have felt _slightly_ more sensible to me, as no use in checking for availability of a service if one isn't going to use it anyway - but, this is only a small nit and could be easily addressed anytime - so mostly mentioning it to get it off my mind ;-)