From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0593C1FF15E for ; Mon, 29 Sep 2025 20:01:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7279C1871B; Mon, 29 Sep 2025 20:02:00 +0200 (CEST) Message-ID: <6bec1049-d818-4973-8fd9-cc8a60b2d1ae@proxmox.com> Date: Mon, 29 Sep 2025 20:01:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pdm-devel@lists.proxmox.com References: <20250929154820.892720-1-c.ebner@proxmox.com> <20250929154820.892720-4-c.ebner@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20250929154820.892720-4-c.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759168866453 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH proxmox 3/3] proxmox-login: add compat mode to fallback to PBS3 ticket parsing X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On 9/29/25 5:48 PM, Christian Ebner wrote: > The ticket info field is present for Proxmox Backup Server version 3 > login response data, the client however switches to http-only in this > case. > > Allow to use the old authentication workflow instead by extending the > compat mode by `Pbs3Ticket`, resulting in a full ticket instead of > the http-only one. > > Signed-off-by: Christian Ebner > --- > proxmox-login/src/lib.rs | 21 ++++++++++++--------- > 1 file changed, 12 insertions(+), 9 deletions(-) > > diff --git a/proxmox-login/src/lib.rs b/proxmox-login/src/lib.rs > index e7b8e023..93d09a8c 100644 > --- a/proxmox-login/src/lib.rs > +++ b/proxmox-login/src/lib.rs > @@ -58,6 +58,7 @@ pub enum CompatMode { > #[default] > Generic, > PveTfa, > + Pbs3Ticket, > } > > fn normalize_url(mut api_url: String) -> String { > @@ -216,15 +217,17 @@ impl Login { > )); > } > > - // `ticket_info` is set when the server sets the ticket via an HttpOnly cookie. this also > - // means we do not have access to the cookie itself which happens for example in a browser. > - // assume that the cookie is handled properly by the context (browser) and don't worry > - // about handling it ourselves. > - if let Some(ref ticket) = response.ticket_info { > - let ticket = ticket.parse()?; > - return Ok(TicketResult::HttpOnly( > - self.authentication_for(ticket, response)?, > - )); > + if self.compat_mode == CompatMode::Pbs3Ticket { This is wrong, should have been a check for !CompatMOde::Pbs3Ticket Please disregard this series, I will send a v2.. _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel