From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3709D1FF165 for ; Thu, 6 Nov 2025 10:22:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B04C611315; Thu, 6 Nov 2025 10:22:49 +0100 (CET) Message-ID: <6bebe9f1-b8d1-4e96-a7bb-30deb71e33a1@proxmox.com> Date: Thu, 6 Nov 2025 10:22:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Nicolas Frey References: <20251105155129.517430-1-n.frey@proxmox.com> <20251105155129.517430-6-n.frey@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20251105155129.517430-6-n.frey@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762420917991 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 4/4] ui: verify: add option to set number of threads for job X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Same comment with respect to commit title as for some of the other patches, a short description on why this is done would be nice. E.g. Exposes the worker-threads property in the verification job config window and verify all window so the user can update the values accordingly. one comment below On 11/5/25 4:51 PM, Nicolas Frey wrote: > Signed-off-by: Nicolas Frey > --- > www/window/VerifyAll.js | 12 ++++++++++++ > www/window/VerifyJobEdit.js | 13 +++++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/www/window/VerifyAll.js b/www/window/VerifyAll.js > index 01bcd63d..82f62aae 100644 > --- a/www/window/VerifyAll.js > +++ b/www/window/VerifyAll.js > @@ -80,6 +80,18 @@ Ext.define('PBS.window.VerifyAll', { > }, > ], > }, > + > + { > + xtype: 'proxmoxintegerfield', > + name: 'worker-threads', > + fieldLabel: gettext('# of Worker Threads'), > + emptyText: '1', > + minValue: 1, > + maxValue: 32, > + cbind: { > + deleteEmpty: '{!isCreate}', > + }, > + }, > ], > }, > ], > diff --git a/www/window/VerifyJobEdit.js b/www/window/VerifyJobEdit.js > index e87ca069..7b7a96c4 100644 > --- a/www/window/VerifyJobEdit.js > +++ b/www/window/VerifyJobEdit.js > @@ -166,5 +166,18 @@ Ext.define('PBS.window.VerifyJobEdit', { > }, > }, > ], > + advancedColumn2: [ > + { > + xtype: 'proxmoxintegerfield', > + name: 'worker-threads', > + fieldLabel: gettext('# of Worker Threads'), > + emptyText: '1', > + minValue: 1, > + maxValue: 32, > + cbind: { > + deleteEmpty: '{!isCreate}', > + }, > + }, > + ] it would be nice to also delete the value again if set to the default. Further, just noticed: this now seemingly defaults to 1, which is also the default for the API schema, but the parallel task instantiation gets a default of 4 if the value is not set and therefore unwrapped? That should be made consistent. > }, > }); _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel