From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <l.stechauner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A021A6EFAE for <pbs-devel@lists.proxmox.com>; Fri, 27 Aug 2021 10:03:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 90A89226CA for <pbs-devel@lists.proxmox.com>; Fri, 27 Aug 2021 10:03:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 99CDB226BC for <pbs-devel@lists.proxmox.com>; Fri, 27 Aug 2021 10:03:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 67B9343868 for <pbs-devel@lists.proxmox.com>; Fri, 27 Aug 2021 10:03:13 +0200 (CEST) To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Hannes Laimer <h.laimer@proxmox.com> References: <20210819110343.8708-1-h.laimer@proxmox.com> From: Lorenz Stechauner <l.stechauner@proxmox.com> Message-ID: <6986005e-c1ee-2a69-f67e-0912857b1427@proxmox.com> Date: Fri, 27 Aug 2021 10:03:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210819110343.8708-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 1.480 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [status.rs, datastore.rs, proxmox-backup-manager.rs, mod.rs, lib.rs, proxmox-backup-api.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup 00/15] (partially)close #3156: Add support for removable datastores X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 27 Aug 2021 08:03:18 -0000 Hi, after fighting against the Rust compiler and PBS datastores, I was finally able to test this series :) Everything works as expected, with some room for improvements: * I accidentally achieved that the root partition was the backing-storage of my removable datastore. Unmounting this datastore lead to the root partition being unmounted – not ideal. I can imagine two possible solutions: 1.) do not ever unmount "/" (check before unmounting) and 2.) check on creation of the datastore, if the backing device is *really* a removable device * At the moment only the UUID of the FS is shown in the Options tab. Perhaps also showing the configured backing path (=mount point) would also be an option. I think, humans can handle short paths a bit better than "random" uuids ;) (tested with virtual disks and a physical usb stick) Other comments, not related to this series: * I was not able to find the "Remove Datastore" button myself – I simply didn't see it. It blew my mind, when Hannes showed me this button :P On 19.08.21 13:03, Hannes Laimer wrote: > Adds the possibility to create removable datastores. A removable > datastore has a UUID(the device on which the data is stored) and a > mount-point(where the device will be mounted), iff both are set the > datastore is removable. Everything else is identical to normal > datastores. Since config files for jobs, etc. are stored on the server, > all configuration can be done with the device plugged in or not. Certain > statistics about the datastore won't be available as long as it is not > plugged in. > Removable datastores have to be unmounted before removing, it can only > be unmounted if not jibs are running. > Removable datastores are mounted automatically when the device is plugged in, if it has > been unmounted, it has to be mounted manually through the WebUI or the Api. > Jobs will not be started if the datastore is not available, and > depending on the configuration, start when the device is plugged in the > next time. > > Still todo: > - make sync to local datastore more integrated > - (add 'when plugged in'-option to job schedule?) > - replace linux commands with internal functions in tools/disks, where > possible > > Hannes Laimer (15): > tools: add disks utility functions > config: add uuid+mountpoint to DataStoreConfig > api2: add support for removable datastore creation > backup: add check_if_available function to ds > api2: add 'is_available' to DataStoreConfig > api2: add 'removable' to DataStoreListItem > api2: add (un)mount endpoint for removable ds's > pbs: add mount-removable command to commandSocket > pbs-manager: add 'send-command' command > debian: add udev rule for removable datastores > ui: show usb icon for removable datastore in list > ui: add 'removable' checkbox in datastore creation > ui: display row as disabled in ds statistics > ui: show backing device UUID in option tab > ui: add (un)mount button to summary > > debian/proxmox-backup-server.udev | 3 + > pbs-api-types/src/lib.rs | 7 ++ > src/api2/admin/datastore.rs | 159 +++++++++++++++++++++++++++ > src/api2/config/datastore.rs | 19 +++- > src/api2/status.rs | 19 +++- > src/api2/types/mod.rs | 2 + > src/backup/datastore.rs | 23 ++++ > src/backup/mod.rs | 2 +- > src/bin/proxmox-backup-api.rs | 27 +++++ > src/bin/proxmox-backup-manager.rs | 41 +++++++ > src/config/datastore.rs | 16 +++ > src/tools/disks/mod.rs | 53 +++++++++ > www/NavigationTree.js | 3 +- > www/dashboard/DataStoreStatistics.js | 3 + > www/datastore/OptionView.js | 3 + > www/datastore/Summary.js | 77 ++++++++++++- > www/window/DataStoreEdit.js | 5 + > 17 files changed, 454 insertions(+), 8 deletions(-) >