From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id E51411FF0A7 for ; Wed, 02 Sep 2026 11:07:29 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 058D2212EE; Wed, 02 Sep 2026 11:07:29 +0200 (CEST) Message-ID: <68dc75cb-ec7a-41f3-98b2-51f3f9e51740@proxmox.com> Date: Wed, 2 Sep 2026 11:07:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox v2 2/2] oci: tests: generate OCI test images on the fly From: Filip Schauer To: pve-devel@lists.proxmox.com References: <20260720095030.64797-1-f.schauer@proxmox.com> <20260720095030.64797-3-f.schauer@proxmox.com> Content-Language: en-US In-Reply-To: <20260720095030.64797-3-f.schauer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788340031777 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.782 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BFWRRYM5GWUMALS42JT2KJ5HZLCTFOYQ X-Message-ID-Hash: BFWRRYM5GWUMALS42JT2KJ5HZLCTFOYQ X-MailFrom: f.schauer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 20/07/2026 11:52, Filip Schauer wrote: > Get rid of the pre-built tar files and instead generate them on the fly. > This makes the tests easier to understand and it is also easier to write > new tests this way. > > This also fixes extraction failures when running tests as a non-root > user. The old tar files used UID/GID 0 for all layer entries, whereas > now the effective UID/GID of the test runner is used instead. Append the following paragraph to the commit message: This also fixes accidental OCI spec violations in oci_test_replace_dir_with_file.tar and oci_test_whiteout_current_directory.tar where the order of the "layers" in the image manifest did not match the order of the "diff_ids" in the image configuration. --- It would be nice to get this applied, since I am currently working on a series that depends on these patches.