From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 512F51FF13C for ; Thu, 02 Apr 2026 00:32:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 14759282C; Thu, 2 Apr 2026 00:32:59 +0200 (CEST) Message-ID: <68a1a699-631e-4485-ba30-a79d46dbf6db@proxmox.com> Date: Thu, 2 Apr 2026 00:32:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-backup v7 26/34] ui: utils: add helper to render notification threshold property string To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260401134817.926499-1-c.ebner@proxmox.com> <20260401134817.926499-27-c.ebner@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260401134817.926499-27-c.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775082717937 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.500 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JYWOMQV7R3HTQRZYJ7UKKE6BMGPMTLSH X-Message-ID-Hash: JYWOMQV7R3HTQRZYJ7UKKE6BMGPMTLSH X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 01.04.26 um 15:48 schrieb Christian Ebner: > Show thresholds as comma and space separated list of configured values, > skipping empty ones. > > Signed-off-by: Christian Ebner > Reviewed-by: Hannes Laimer > Tested-by: Hannes Laimer > --- > www/Utils.js | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/www/Utils.js b/www/Utils.js > index 25fba16f9..d2f3a3c99 100644 > --- a/www/Utils.js > +++ b/www/Utils.js > @@ -933,4 +933,13 @@ Ext.define('PBS.Utils', { > > return options.join(', '); > }, > + > + render_notification_thresholds: function (notificationThresholds) { > + let thresholds = []; > + for (const [k, v] of Object.entries(notificationThresholds)) { > + thresholds.push(`${k}: ${v}`); > + } > + > + return thresholds.join(', '); > + }, Could use a map directly: render_notification_thresholds: (notificationThresholds) => Object.entries(notificationThresholds) .map(([k, v]) => `${k}: ${v}`) .join(', '), and potentially add `?? gettext('None')` for the fallback? And FWIW, should also probably be inline directly, it's simple and only used once after all. > });