From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D32CE60343 for <pve-devel@lists.proxmox.com>; Fri, 16 Oct 2020 14:50:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C57291B450 for <pve-devel@lists.proxmox.com>; Fri, 16 Oct 2020 14:50:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 173761B440 for <pve-devel@lists.proxmox.com>; Fri, 16 Oct 2020 14:50:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DD69D45DB5 for <pve-devel@lists.proxmox.com>; Fri, 16 Oct 2020 14:50:02 +0200 (CEST) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stefan Reiter <s.reiter@proxmox.com> References: <20201006133218.25403-1-s.reiter@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <68765fe3-d700-73f9-5169-45b05cc7c0fc@proxmox.com> Date: Fri, 16 Oct 2020 14:50:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20201006133218.25403-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.132 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [usb.pm, qemu.pm, pci.pm, sencha.com, qm.pm, drive.pm, qemuserver.pm] Subject: [pve-devel] applied-series: [PATCH v2 0/7] Improve boot device/order configuration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 16 Oct 2020 12:50:34 -0000 On 06.10.20 15:32, Stefan Reiter wrote: > The goal of the series is to modernize boot order selection by allowing the user > to specify arbitrary VM disks and devices in any order. Fixes #3010 and #3011. > > First patch is a standalone cleanup. Tests are seperated into extra patches. > > v2: > * split qemu-server changes into seperate patches (hence changelog only here) > * use order= property in boot: instead of standalone bootorder: > ** update API and GUI to match > * fix get_default_bootdevices and bootorder_from_legacy to *actually* match the > old behaviour, as is now verified with the test > => see GUI patch for changes there > > > qemu-server: Stefan Reiter (6): > fix indentation > cfg2cmd: add test for legacy-style bootorder > add new 'boot' property format and introduce legacy conversion helpers > fix #3010: add 'bootorder' parameter for better control of boot > devices > api: add handling for new boot order format > cfg2cmd: add tests for new boot order property > > PVE/API2/Qemu.pm | 37 ++++- > PVE/CLI/qm.pm | 4 +- > PVE/QemuServer.pm | 207 ++++++++++++++++++++----- > PVE/QemuServer/Drive.pm | 32 +++- > PVE/QemuServer/PCI.pm | 3 +- > PVE/QemuServer/USB.pm | 14 +- > test/cfg2cmd/bootorder-empty.conf | 16 ++ > test/cfg2cmd/bootorder-empty.conf.cmd | 38 +++++ > test/cfg2cmd/bootorder-legacy.conf | 17 ++ > test/cfg2cmd/bootorder-legacy.conf.cmd | 38 +++++ > test/cfg2cmd/bootorder.conf | 16 ++ > test/cfg2cmd/bootorder.conf.cmd | 38 +++++ > 12 files changed, 398 insertions(+), 62 deletions(-) > create mode 100644 test/cfg2cmd/bootorder-empty.conf > create mode 100644 test/cfg2cmd/bootorder-empty.conf.cmd > create mode 100644 test/cfg2cmd/bootorder-legacy.conf > create mode 100644 test/cfg2cmd/bootorder-legacy.conf.cmd > create mode 100644 test/cfg2cmd/bootorder.conf > create mode 100644 test/cfg2cmd/bootorder.conf.cmd > > manager: Stefan Reiter (1): > ui: improve boot order editor with 'bootorder' support > > www/css/ext6-pve.css | 4 + > www/manager6/qemu/BootOrderEdit.js | 355 ++++++++++++++++++----------- > www/manager6/qemu/Options.js | 32 ++- > 3 files changed, 257 insertions(+), 134 deletions(-) > applied series, thanks! I did a few smaller followups for the webinterface though, nothing big, the only thing you may want to check out for the future is the use of the defaults property for defaults covering all/most items: https://docs.sencha.com/extjs/6.0.1/classic/Ext.grid.Panel.html#cfg-defaults