From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6CF9E1FF136 for ; Mon, 18 May 2026 18:02:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D308617AB0; Mon, 18 May 2026 18:02:23 +0200 (CEST) Message-ID: <67f2c2d6-a4af-4ad0-85b2-68b6eb9e17d6@proxmox.com> Date: Mon, 18 May 2026 18:02:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH manager/pmg-api/proxmox{,-backup,-perl-rs,-offline-mirror} 0/8] adapt subscription handling to alternative server IDs To: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= , pve-devel@lists.proxmox.com References: <20260507115957.1497272-1-f.gruenbichler@proxmox.com> Content-Language: en-US From: Samuel Rufinatscha In-Reply-To: <20260507115957.1497272-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.223 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [subscription.pm,proxmox-offline-mirror.rs,lib.rs,utils.pm,subscription.rs,proxmox-offline-mirror-helper.rs,api2tools.pm] Message-ID-Hash: QDBUZMN2P7FTXVGUULP6WDS4G2I5GQZA X-Message-ID-Hash: QDBUZMN2P7FTXVGUULP6WDS4G2I5GQZA X-MailFrom: s.rufinatscha@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Please find below a summary of the tests i performed: PVE: - existing SshMd5 subscription stays "active" after the patch - update using --force on a pre-existing subscription works - delete + set without reissue is rejected with "Invalid Server ID" as expected, since the patched client sends MachineId - After reissue, delete + set binds the subscription to the new MachineId - Regenerating the SSH host keys on a MachineId-bound subscription does not change its status, no reissue needed PMG: tested the same scenarios as PVE POM: - existing SshMd5 mirror subscription stays "active" after the patch - key refresh on a pre-existing subscription works - key remove + key add-mirror-key without reissue is rejected with "Invalid Server ID" as expected For PDM I tested if the subscription of the patched remote shows up as active in the PDM system report. Tested using a Community Subscription. I didn't run into any errors and didn't notice anything that looks off. Tested-by: Samuel Rufinatscha On 5/7/26 1:59 PM, Fabian Grünbichler wrote: > instead of only supporting one variant of server IDs, get a list of possible > candidates via the proxmox-subscription crate. if a subscription is already > configured, the matching server ID will be reused to avoid reissuing. > > v1: > - drop proxmox-systemd part, already applied > - add PMG changes > - add PDM changes > - add POM changes > - rebase > > order of bumping: > - proxmox-subscription (breaks PBS/PDM/POM) > > - pve-rs/pmg-rs (needs proxmox-subscription) > - pve-manager (needs pve-rs) > - pmg-api (needs pmg-rs) > > - pbs (needs proxmox-subscription) > > - pdm (needs proxmox-subscription) > > - pom (needs proxmox-subscription) > > tested PBS/PVE, additional testing of PMG/POM/PDM would be highly > appreciated. > > sending to pve-devel, since it's our main list - this of course is a > cross-product patch series ;) > > > proxmox: > > Fabian Grünbichler (1): > proxmox-subscription: add new machine-id based serverid > > proxmox-subscription/Cargo.toml | 3 +- > proxmox-subscription/src/lib.rs | 2 +- > proxmox-subscription/src/subscription_info.rs | 105 ++++++++++++++++-- > 3 files changed, 96 insertions(+), 14 deletions(-) > > > proxmox-backup: > > Fabian Grünbichler (1): > subscription: adapt to multiple server ID variants > > src/api2/node/subscription.rs | 38 ++++++++++++++++++++++++++--------- > 1 file changed, 28 insertions(+), 10 deletions(-) > > > proxmox-perl-rs: > > Fabian Grünbichler (1): > common: subscription: expose server ID candidates > > common/src/bindings/subscription.rs | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > > pve-manager: > > Fabian Grünbichler (2): > subscription: adapt to multiple server ID variants > api2tools: remove unused get_hwaddress > > PVE/API2/Subscription.pm | 26 ++++++++++++++++++++------ > PVE/API2Tools.pm | 23 ----------------------- > 2 files changed, 20 insertions(+), 29 deletions(-) > > > pmg-api: > > Fabian Grünbichler (2): > subscription: adapt to multiple server ID variants > utils: drop now unused get_hwaddress > > src/PMG/API2/Subscription.pm | 27 +++++++++++++++++++++------ > src/PMG/Utils.pm | 23 ----------------------- > 2 files changed, 21 insertions(+), 29 deletions(-) > > > proxmox-offline-mirror: > > Fabian Grünbichler (1): > subscription handling: adapt to multiple server ID candidates > > src/bin/proxmox-offline-mirror-helper.rs | 36 +++++++++++++++---- > src/bin/proxmox-offline-mirror.rs | 6 +++- > .../subscription.rs | 5 ++- > 3 files changed, 39 insertions(+), 8 deletions(-) > > > Summary over all repositories: > 12 files changed, 215 insertions(+), 90 deletions(-) >