From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 62BA11FF0AF for ; Thu, 08 Oct 2026 16:49:55 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0081E213C7; Thu, 08 Oct 2026 16:49:53 +0200 (CEST) Message-ID: <679a5b21-4a90-4ee6-8671-47dc6e2775d6@proxmox.com> Date: Thu, 8 Oct 2026 16:49:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server v3 11/21] helpers: move version_cmp() helper to pve-common To: =?UTF-8?Q?Michael_K=C3=B6ppl?= , pve-devel@lists.proxmox.com References: <20260918160841.128088-1-f.ebner@proxmox.com> <20260918160841.128088-12-f.ebner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791470988462 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.450 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KL5VGBT66TBUX3WJYSYZ3GP4M7OFGGXR X-Message-ID-Hash: KL5VGBT66TBUX3WJYSYZ3GP4M7OFGGXR X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Good catch! That function got newly added since I sent the series. Needs to be fixed in a v4 or upon applying. Am 08.10.26 um 4:46 PM schrieb Michael Köppl: > Noticed that QemuServer::Drive::virtio_win_iso_issue still uses > PVE::QemuServer::Helpers::version_cmp. > > On Fri Sep 18, 2026 at 6:08 PM CEST, Fiona Ebner wrote: >> Signed-off-by: Fiona Ebner >> --- >> >> New in v3. >> >> src/PVE/QemuServer/Helpers.pm | 30 ++---------------------------- >> src/PVE/QemuServer/Machine.pm | 13 +++++-------- >> src/PVE/QemuServer/QMPHelpers.pm | 5 +++-- >> 3 files changed, 10 insertions(+), 38 deletions(-) >> >> diff --git a/src/PVE/QemuServer/Helpers.pm b/src/PVE/QemuServer/Helpers.pm >> index dd17eef5..a39e4abf 100644 >> --- a/src/PVE/QemuServer/Helpers.pm >> +++ b/src/PVE/QemuServer/Helpers.pm >> @@ -228,39 +228,13 @@ sub min_version { >> my ($verstr, $major, $minor, $pve) = @_; > > [snip]