From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 8F7C0901FE;
 Wed,  5 Oct 2022 17:45:51 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 688853EF4;
 Wed,  5 Oct 2022 17:45:21 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS;
 Wed,  5 Oct 2022 17:45:20 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 95A6D445DA;
 Wed,  5 Oct 2022 17:45:20 +0200 (CEST)
Message-ID: <677a9e78-033e-dfb5-9057-8b1eff231c96@proxmox.com>
Date: Wed, 5 Oct 2022 17:45:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101
 Thunderbird/106.0
Content-Language: en-GB
To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>, Matthias Heiserer <m.heiserer@proxmox.com>,
 pmg-devel@lists.proxmox.com
References: <20220720122256.483511-1-m.heiserer@proxmox.com>
 <20220720122256.483511-3-m.heiserer@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20220720122256.483511-3-m.heiserer@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 1.194 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -2.449 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH widget-toolkit] CSS: import action column
 fix from pbs, pmg
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 05 Oct 2022 15:45:51 -0000

Am 20/07/2022 um 14:22 schrieb Matthias Heiserer:
> So it is in one location and available to pve as well.
> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>  src/css/ext6-pmx.css | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/src/css/ext6-pmx.css b/src/css/ext6-pmx.css
> index 886e24a..2286003 100644
> --- a/src/css/ext6-pmx.css
> +++ b/src/css/ext6-pmx.css
> @@ -274,3 +274,18 @@ div.right-aligned {
>  /* markdown tables end */
>  
>  /* markdown content end */
> +
> +/* fix action column icons */
> +.x-action-col-icon:before {
> +    color: #555;
> +}
> +
> +.x-action-col-icon {
> +    font-size: 13px;
> +    height: 13px;
> +}

this is using the outdated/wrong ones, the font awesome icons we use are 14px.
Please use the modern ones from PBS and maybe add the additional ones, like:

.x-action-col-icon {
    margin: 0 1px;
    font-size: 14px;
}
.x-action-col-icon:before, .x-action-col-icon:after {
    font-size: 14px;
}
.x-action-col-icon:hover:before, .x-action-col-icon:hover:after {
    text-shadow: 1px 1px 1px #AAA;
    font-weight: 800;
}

Note that it's a bit confusing because in PBS the previous & wrong 13px font-size
rule didn't get removed..


> +
> +.x-grid-cell-inner-action-col {
> +    padding: 6px 10px 5px;
> +}
> +/* fix action column icons end*/
> \ No newline at end of file





From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 8F7C0901FE;
 Wed,  5 Oct 2022 17:45:51 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 688853EF4;
 Wed,  5 Oct 2022 17:45:21 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS;
 Wed,  5 Oct 2022 17:45:20 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 95A6D445DA;
 Wed,  5 Oct 2022 17:45:20 +0200 (CEST)
Message-ID: <677a9e78-033e-dfb5-9057-8b1eff231c96@proxmox.com>
Date: Wed, 5 Oct 2022 17:45:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101
 Thunderbird/106.0
Content-Language: en-GB
To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>, Matthias Heiserer <m.heiserer@proxmox.com>,
 pmg-devel@lists.proxmox.com
References: <20220720122256.483511-1-m.heiserer@proxmox.com>
 <20220720122256.483511-3-m.heiserer@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20220720122256.483511-3-m.heiserer@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 1.194 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -2.449 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pmg-devel] [pbs-devel] [PATCH widget-toolkit] CSS: import
 action column fix from pbs, pmg
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
 <pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 05 Oct 2022 15:45:51 -0000

Am 20/07/2022 um 14:22 schrieb Matthias Heiserer:
> So it is in one location and available to pve as well.
> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>  src/css/ext6-pmx.css | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/src/css/ext6-pmx.css b/src/css/ext6-pmx.css
> index 886e24a..2286003 100644
> --- a/src/css/ext6-pmx.css
> +++ b/src/css/ext6-pmx.css
> @@ -274,3 +274,18 @@ div.right-aligned {
>  /* markdown tables end */
>  
>  /* markdown content end */
> +
> +/* fix action column icons */
> +.x-action-col-icon:before {
> +    color: #555;
> +}
> +
> +.x-action-col-icon {
> +    font-size: 13px;
> +    height: 13px;
> +}

this is using the outdated/wrong ones, the font awesome icons we use are 14px.
Please use the modern ones from PBS and maybe add the additional ones, like:

.x-action-col-icon {
    margin: 0 1px;
    font-size: 14px;
}
.x-action-col-icon:before, .x-action-col-icon:after {
    font-size: 14px;
}
.x-action-col-icon:hover:before, .x-action-col-icon:hover:after {
    text-shadow: 1px 1px 1px #AAA;
    font-weight: 800;
}

Note that it's a bit confusing because in PBS the previous & wrong 13px font-size
rule didn't get removed..


> +
> +.x-grid-cell-inner-action-col {
> +    padding: 6px 10px 5px;
> +}
> +/* fix action column icons end*/
> \ No newline at end of file