From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0E8DF9E4A3 for <pbs-devel@lists.proxmox.com>; Mon, 27 Nov 2023 13:06:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E2DFB6DC5 for <pbs-devel@lists.proxmox.com>; Mon, 27 Nov 2023 13:06:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Mon, 27 Nov 2023 13:06:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2B0B544BF0 for <pbs-devel@lists.proxmox.com>; Mon, 27 Nov 2023 13:06:02 +0100 (CET) Message-ID: <66fbb58b-1c99-4c06-bf6a-ea308ee6fdd3@proxmox.com> Date: Mon, 27 Nov 2023 13:06:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB-large To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20230801092954.1686860-1-d.csapak@proxmox.com> <20230801092954.1686860-4-d.csapak@proxmox.com> <6d286eab-604e-408a-b0d1-8ba5990af97f@proxmox.com> <c7f8f597-206a-49c9-9d39-8ba2292a2cfb@proxmox.com> <5c7c34b9-2729-417e-82b4-25b77853d910@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <5c7c34b9-2729-417e-82b4-25b77853d910@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/3] ui: datastore content: add action to show upload statistics X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 27 Nov 2023 12:06:03 -0000 On 27.11.23 11:15, Dominik Csapak wrote: > On 11/27/23 11:07, Thomas Lamprecht wrote: >> On 27.11.23 10:28, Thomas Lamprecht wrote: >>> we'd not add a core UI element for a rather niche information >>> that most won't look at often. >> >> re-thinking this, maybe we want to put those things into a context >> menu and expose that menu with a fa-bars or fa-toggle-down icon, >> in addition with allowing one to trigger it with a standard right >> click context menu (I wanted to add that for datastore content UI >> since quite a while already). > > sure, doesn't sound too complicated. i'd put the remaining actions > also there. would you then still prefer a "general info" panel > over just showing the upload statistics? (i guess so, but want > to make sure) Yes, and I'd also like that this is split (patch-wise) a bit so that we do not have to use all or nothing now. I.e., add context menu for existing actions and wire it up to right click, that on it's own is a nice feature and doesn't needs anything else mixed in. Then add the new info thingy and add it only there for now. Then rework a few of the existing actions out and add a (possibly slightly filtered) fa-bars trigger-able menu there). IMO while the other ones are relatively clear, this one has the most potential for different opinion and UX workflow design and I'd not like to being forced to rush that if I want the other (above) features now already.