From: Jonas Theisen <j.theisen@proxmox.com>
To: pve-devel@lists.proxmox.com, "Michael Köppl" <m.koeppl@proxmox.com>
Subject: Re: [PATCH manager 1/1] cephx: rename 'consumer' to 'client' in output and comments
Date: Tue, 15 Sep 2026 17:34:37 +0200 [thread overview]
Message-ID: <66f9b8ad-b262-4a3a-9ec8-3179ef3a5437@proxmox.com> (raw)
In-Reply-To: <20260915145047.754765-1-m.koeppl@proxmox.com>
On 9/15/26 16:50, Michael Köppl wrote:
> 'Client' is the term more often used in the Proxmox VE documentation and
> 'consumer' has been replaced by 'client' in the Ceph documentation to
> avoid confusion [0]. `pveceph auth status` and the cephx health hints in
> the GUI still used the old 'consumer'. Update output strings and
> comments accordingly. This change is made to conform to the updated
> documentation and the naming change in the cephx migration script.
>
> [0] https://docs.ceph.com/en/latest/dev/cephx/
>
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
> Sent as a separate patch but meant as a follow-up to [1].
>
> [1] https://lore.proxmox.com/pve-devel/20260915131651.515520-1-m.koeppl@proxmox.com
>
> <snip>
Looks good to me.
Nearly all the remaining occurrences of 'consumer' are
in variable or function names.
There are still two 'consumers' in Services.pm line 938 and 1019
but since these are code comments i don't see that as a blocker.
Consider this:
Reviewed-by: Jonas Theisen <j.theisen@proxmox.com>
next prev parent reply other threads:[~2026-09-15 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 14:50 [PATCH manager 1/1] cephx: rename 'consumer' to 'client' in output and comments Michael Köppl
2026-09-15 15:34 ` Jonas Theisen [this message]
2026-09-16 12:05 ` Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66f9b8ad-b262-4a3a-9ec8-3179ef3a5437@proxmox.com \
--to=j.theisen@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.