all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Robert Obkircher <r.obkircher@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox{,-backup} 0/9] support index readers on larger page sizes
Date: Mon, 14 Sep 2026 13:47:34 +0200	[thread overview]
Message-ID: <661d7d35-e5b5-426e-ab78-b9f951285437@proxmox.com> (raw)
In-Reply-To: <20260731142430.289893-1-r.obkircher@proxmox.com>

On 7/31/26 4:25 PM, Robert Obkircher wrote:
> Fix `proxmox-backup-client restore` and pbs in general on systems with
> a larger page size.
> 
> Also ensure that `proxmox-backup-debug inspect` displays a consistent
> size for fixed and dynamic index files, and include the total backup
> size in the output.
> 
> proxmox:
> 
> Robert Obkircher (1):
>    proxmox-sys: add len and as_non_null method to Mmap
> 
>   proxmox-sys/src/mmap.rs | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
> 
> 
> proxmox-backup:
> 
> Robert Obkircher (8):
>    datastore: limit scope of mutable reference in FixedIndexWriter::close
>    datastore: add tests for fixed and dynamic index reader
>    datastore: fix inconsistent implementation of index_size method
>    bin: debug: print referenced backup size for index files
>    datastore: check that index files are regular files
>    datastore: simplify FixedIndexReader::chunk_info
>    datastore: always access dynamic index reader slice through method
>    fix #7244: datastore: always mmap index files from offset 0
> 
>   pbs-datastore/src/dynamic_index.rs      | 154 ++++++++++++-------
>   pbs-datastore/src/fixed_index.rs        | 195 +++++++++++++-----------
>   pbs-datastore/src/index.rs              |   5 +
>   pbs-datastore/src/index_mmap.rs         | 171 +++++++++++++++++++++
>   pbs-datastore/src/lib.rs                |   1 +
>   src/bin/proxmox_backup_debug/inspect.rs |   4 +
>   6 files changed, 387 insertions(+), 143 deletions(-)
>   create mode 100644 pbs-datastore/src/index_mmap.rs
> 
> 
> Summary over all repositories:
>    7 files changed, 402 insertions(+), 143 deletions(-)

Verified restores via proxmox-backup-client, sync jobs as well as build 
for proxmox-backukp-qemu and pbs-restore are unaffected with patches 
applied:

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>




      parent reply	other threads:[~2026-09-14 11:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31 14:21 [PATCH proxmox{,-backup} 0/9] support index readers on larger page sizes Robert Obkircher
2026-07-31 14:21 ` [PATCH proxmox 1/9] proxmox-sys: add len and as_non_null method to Mmap Robert Obkircher
2026-07-31 14:21 ` [PATCH proxmox-backup 2/9] datastore: limit scope of mutable reference in FixedIndexWriter::close Robert Obkircher
2026-07-31 14:21 ` [PATCH proxmox-backup 3/9] datastore: add tests for fixed and dynamic index reader Robert Obkircher
2026-07-31 14:21 ` [PATCH proxmox-backup 4/9] datastore: fix inconsistent implementation of index_size method Robert Obkircher
2026-07-31 14:21 ` [PATCH proxmox-backup 5/9] bin: debug: print referenced backup size for index files Robert Obkircher
2026-07-31 14:21 ` [PATCH proxmox-backup 6/9] datastore: check that index files are regular files Robert Obkircher
2026-09-14 11:17   ` Christian Ebner
2026-07-31 14:21 ` [PATCH proxmox-backup 7/9] datastore: simplify FixedIndexReader::chunk_info Robert Obkircher
2026-07-31 14:21 ` [PATCH proxmox-backup 8/9] datastore: always access dynamic index reader slice through method Robert Obkircher
2026-07-31 14:21 ` [PATCH proxmox-backup 9/9] fix #7244: datastore: always mmap index files from offset 0 Robert Obkircher
2026-09-14 11:47 ` Christian Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=661d7d35-e5b5-426e-ab78-b9f951285437@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=r.obkircher@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal