From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B69231FF138 for ; Wed, 04 Mar 2026 09:43:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A528D3554; Wed, 4 Mar 2026 09:44:35 +0100 (CET) Message-ID: <65d19be4-8ee5-41b1-ae93-88f435035ac8@proxmox.com> Date: Wed, 4 Mar 2026 09:44:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH backup v3 2/3] docs: client: document further password constrains To: Maximiliano Sandoval , pbs-devel@lists.proxmox.com References: <20260223093710.36009-1-m.sandoval@proxmox.com> <20260223093710.36009-3-m.sandoval@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260223093710.36009-3-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772613846687 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UKQBCMUL5UBU2H3UTDUAK2TZEVDOVEIU X-Message-ID-Hash: UKQBCMUL5UBU2H3UTDUAK2TZEVDOVEIU X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: one nit inline On 2/23/26 10:37 AM, Maximiliano Sandoval wrote: > We leave the explicit newlines as "control character" might not mean > much to some readers. > > Signed-off-by: Maximiliano Sandoval > --- > docs/backup-client.rst | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/docs/backup-client.rst b/docs/backup-client.rst > index 40962f0e2..03a383d9c 100644 > --- a/docs/backup-client.rst > +++ b/docs/backup-client.rst > @@ -104,9 +104,10 @@ Environment Variables > wireguard, instead of using an HTTP proxy. > > > -.. Note:: Passwords must be valid UTF-8 and may not contain newlines. For your > - convenience, Proxmox Backup Server only uses the first line as password, so > - you can add arbitrary comments after the first newline. > +.. Note:: Passwords must be valid UTF-8 and may not contain newlines or any > + control characters in general. For your convenience, Proxmox Backup Server nit: I suggest to drop the ` in general` here or even rephrase to `may not contain any control characters or newlines.`. The `in general` makes it less concise IMO, without providing additional relevant information. > + only uses the first line as password, so you can add arbitrary comments after > + the first newline. > > > System and Service Credentials