From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C0AC81FF137 for ; Tue, 03 Mar 2026 21:09:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0E47330E36; Tue, 3 Mar 2026 21:10:26 +0100 (CET) Message-ID: <65bac8ca-7d95-47fd-83d0-3af5ee22c77b@proxmox.com> Date: Tue, 3 Mar 2026 21:09:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH ha-manager v2] resources: Expand max_restart option To: Maximiliano Sandoval , pve-devel@lists.proxmox.com References: <20260303132206.222398-1-m.sandoval@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260303132206.222398-1-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772568566260 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.081 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.66 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.968 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.495 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YTCVQC26KD3BQ77EL55O3VCP7TGJMKLZ X-Message-ID-Hash: YTCVQC26KD3BQ77EL55O3VCP7TGJMKLZ X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 03.03.26 um 14:22 schrieb Maximiliano Sandoval: > When read next to `max_relocate` it is not clear which happens first > after a service fails to start. > > Signed-off-by: Maximiliano Sandoval > > --- > > Differences from v1: > - Incorporate feedback. Namely, "the service will be attempted to be relocated" > was a bit too convoluted. > > src/PVE/HA/Resources.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm > index 68d9d16..404f6dc 100644 > --- a/src/PVE/HA/Resources.pm > +++ b/src/PVE/HA/Resources.pm > @@ -73,7 +73,8 @@ EODESC > }, > max_restart => { > description => "Maximal number of tries to restart the service on" > - . " a node after its start failed.", > + . " a node after its start failed. When reached, the HA manager will try to" > + . " relocate the service to an eligible node.", IIRC we decided to try using the term "resources" for the VM/CTs managed by HA and "services" more for the daemons for new docs/description (and Someday™ clean up the existing usage). Can be easily fixed up on applying, just wanted to ensure I did not misremember (CCing also Dano for that) > type => 'integer', > optional => 1, > default => 1,