From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0F6C61FF16B for ; Tue, 1 Jul 2025 10:41:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6CACF39700; Tue, 1 Jul 2025 10:42:36 +0200 (CEST) Message-ID: <657839ef-29c7-420b-8c15-053cf42617ff@proxmox.com> Date: Tue, 1 Jul 2025 10:42:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion References: <20250627155737.162083-1-f.ebner@proxmox.com> <20250627155737.162083-19-f.ebner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 18/31] blockdev: add change_medium() helper X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 01.07.25 um 09:30 schrieb DERUMIER, Alexandre via pve-devel: > Another thing, > > if the vm is start with cdrom=none, then you switch to an iso, > > the throttle group is not generated (+the autogenerated nodenames) Thank you for testing! AFAICS, the throttle group is already generated at VM start, but then not re-generated. It already works after the changes you and Fabian suggested for the attach() and detach() helpers, as the previous throttle group is properly removed beforehand then. But I think, I'll also go for not generating the throttle group for 'none' in the first place. It's not used if there is no associated blockdev, and the limits can always change together with changing the medium (as both happen by updating the VM config line/qm set), so it just makes more sense to only generate it when there is an associated blockdev. Or do you see any problem with that? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel