From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2E5571FF37F for <inbox@lore.proxmox.com>; Thu, 18 Apr 2024 15:38:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C8CC41D791; Thu, 18 Apr 2024 15:38:39 +0200 (CEST) Message-ID: <63b8604ef58f67da05704d612c2464f78fd81f36.camel@proxmox.com> From: Alexander Zeidler <a.zeidler@proxmox.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Date: Thu, 18 Apr 2024 15:38:34 +0200 In-Reply-To: <3e189544-8180-4d51-982e-5e59f4cf13cd@proxmox.com> References: <20240418091650.51366-1-a.zeidler@proxmox.com> <20240418091650.51366-6-a.zeidler@proxmox.com> <3e189544-8180-4d51-982e-5e59f4cf13cd@proxmox.com> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH manager 6/7] report: add info about (un)used memory slots X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On Thu, 2024-04-18 at 12:20 +0200, Mira Limbeck wrote: > On 4/18/24 11:16, Alexander Zeidler wrote: > > * to see if a RAM upgrade is slot/capacity-wise possible > > * to spot added/replaced RAM that may now be causing issues > > > > Maximum Capacity: 2 TB > > Size: 16 GB Part Number: 18ASF2G72PZ-2G6D1 > > Size: 16 GB Part Number: 18ASF2G72PZ-2G6D1 > > Size: 16 GB Part Number: 18ASF2G72PZ-2G6D1 > > Size: 16 GB Part Number: 18ASF2G72PZ-2G6D1 > > Size: No Module Installed > > Size: No Module Installed > > Size: No Module Installed > > Size: No Module Installed > > > > Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com> > > 'dmidecode -t 0,3,32', > > + 'dmidecode -t16,17 | grep -P "^\t(Max[^:]*city|Size|Part)" | sed -Ez "s/\n(\tP[^\n]*)/\1/g" | sort', > Please add a space between `-t` and `16,17`. Ok > > 'lspci -nnk', > > ], > > }, > > To be honest, I'm not a fan of this command. I see. > In those few cases it was > interesting to see, we often wanted to see all the information. And the > full dmidecode -t 17 output is just too much for the report. I agree that the full output is neither often needed nor suitable for the system report. Therefore printing only some information, which can be even more compact as shown here: https://lists.proxmox.com/pipermail/pve-devel/2024-April/063313.html > Not to mention the quite complicated `grep | sed | sort` part that might > break on some systems that report things differently. Hm, from a technical point of view this should still be okay? At least grep and sed is also useful for such (trivial) cases. If it breaks in the future, we should be able to fix it. If we have never used it by then, we can also remove it. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel