all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Michael Köppl" <m.koeppl@proxmox.com>,
	"Fiona Ebner" <f.ebner@proxmox.com>,
	pve-devel@lists.proxmox.com
Subject: Re: [PATCH ha-manager v6 05/26] manager: factor out helper to check if requested resource motion is valid
Date: Thu, 12 Nov 2026 12:00:49 +0100	[thread overview]
Message-ID: <63919262-8934-4709-84c0-e008cb6be0ed@proxmox.com> (raw)
In-Reply-To: <DMSHTCZSSY40.3J572AT5XSV14@proxmox.com>

Am 11.11.26 um 16:39 schrieb Michael Köppl:
> nit: the commit subject is over the limit of 72

fwiw, I'm pondering relaxing that rule for the subject, IMO its overly
limiting and "word golfing" to 72 or below is not exactly a productive
activity. For the body its less of a problem as one can have multiple
lines there anyway.

Maybe something like:
- commit subject should be below 80cc and must be below 120cc

Maybe even similar to our code rule:
- commit subject should be below 100cc and must be below 120cc

That way we have a common guideline of using relatively concise
subjects without forcing brevity just for the sake of it and while
not allowing overly long subject that disrupt the git log etc
experience.

What do you think? I.e., any strong feelings against hat or
preference? I'd just like to avoid redoing this more often.




  reply	other threads:[~2026-11-12 11:00 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 12:47 [PATCH-SERIES many v6 00/26] migration: strict config check for intra-cluster migration Fiona Ebner
2026-11-03 12:47 ` [PATCH common v6 01/26] rest handler: handle: respect schema's 'type-property' when resolving type Fiona Ebner
2026-11-03 12:47 ` [PATCH cluster v6 02/26] cluster: add more convenience helpers for checking node versions Fiona Ebner
2026-11-03 12:47 ` [PATCH ha-manager v6 03/26] manager: add missing PVE::HA::Resources import Fiona Ebner
2026-11-03 12:47 ` [PATCH ha-manager v6 04/26] update crm commands: align logging with next state started/stopped Fiona Ebner
2026-11-03 12:47 ` [PATCH ha-manager v6 05/26] manager: factor out helper to check if requested resource motion is valid Fiona Ebner
2026-11-11 15:39   ` Michael Köppl
2026-11-12 11:00     ` Thomas Lamprecht [this message]
2026-11-12 11:07       ` Fiona Ebner
2026-11-12 11:21         ` Thomas Lamprecht
2026-11-12 11:52           ` Fiona Ebner
2026-11-12 12:23           ` Michael Köppl
2026-11-12 15:35             ` Thomas Lamprecht
2026-11-03 12:47 ` [PATCH ha-manager v6 06/26] next state stopped: align logging for motion command with next_state_started() Fiona Ebner
2026-11-11 15:39   ` Michael Köppl
2026-11-03 12:47 ` [PATCH ha-manager v6 07/26] next state {stopped,started}: factor out helper to handle motion command Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 08/26] lrm: resource migration: support extra migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 09/26] change service state: support hash as a parameter value Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 10/26] next state: handle motion command: support migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 11/26] resources: add migrate_json_properties() method Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 12/26] queue resource motion: support migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 13/26] crm command: support JSON-style migrate command Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 14/26] api: resources: migration: support additional migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 15/26] test: add test for " Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 16/26] helpers: move get_node_pvecfg_version() version helper to pve-cluster Fiona Ebner
2026-11-11 15:39   ` Michael Köppl
2026-11-03 12:48 ` [PATCH qemu-server v6 17/26] api: migrate: allow forwarding certain migration properties to HA Fiona Ebner
2026-11-11 15:40   ` Michael Köppl
2026-11-12  9:21     ` Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 18/26] fix #7053: api: migrate: pass 'with-conntrack-state' flag to HA migration Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 19/26] qm: mtunnel: reply when a command is unknown Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 20/26] qm: mtunnel: add 'conf' command to do strict configuration parsing Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 21/26] migration: intra-cluster: check config can be parsed on target node Fiona Ebner
2026-11-11 15:40   ` Michael Köppl
2026-11-12  9:38     ` Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 22/26] api: migrate: allow forwarding certain migration properties to HA Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 23/26] pct: introduce mtunnel command Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 24/26] d/control: bump versioned build dependency for libpve-common-perl to 9.0.12 Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 25/26] migration: intra-cluster: check config can be parsed on target node Fiona Ebner
2026-11-11 15:41   ` Michael Köppl
2026-11-12 10:50     ` Fiona Ebner
2026-11-03 12:48 ` [PATCH manager v6 26/26] ui: migrate: add checkbox to allow skipping newly enforced config check Fiona Ebner
2026-11-08 23:35 ` applied: (subset) [PATCH-SERIES many v6 00/26] migration: strict config check for intra-cluster migration Thomas Lamprecht
2026-11-11 15:41 ` Michael Köppl
2026-11-11 15:51   ` Michael Köppl
2026-11-12 10:51   ` Fiona Ebner
2026-11-12 11:54 ` superseded: " Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63919262-8934-4709-84c0-e008cb6be0ed@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=m.koeppl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal