From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D7F021FF183 for ; Wed, 13 Aug 2025 13:31:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D40A031FFA; Wed, 13 Aug 2025 13:32:48 +0200 (CEST) Message-ID: <61081edc-1907-462f-957f-1b80e4680a64@proxmox.com> Date: Wed, 13 Aug 2025 13:32:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Maximiliano Sandoval References: <20250813110328.330900-1-m.sandoval@proxmox.com> <9494a5a1-7c49-4f95-8b93-90d6897af421@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755084733294 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.278 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy ENA_SUBJ_ODD_CASE 2.6 Subject has odd case KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox 1/3] time: Add traits to DateTimeValue and TimeSpec X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 8/13/25 13:29, Maximiliano Sandoval wrote: > Dominik Csapak writes: > >> On 8/13/25 13:26, Maximiliano Sandoval wrote: >>> Maximiliano Sandoval writes: >>> >>>> which are useful for tests. >>>> >>>> Signed-off-by: Maximiliano Sandoval >>>> --- >>>> proxmox-time/src/calendar_event.rs | 1 + >>>> proxmox-time/src/date_time_value.rs | 2 +- >>>> 2 files changed, 2 insertions(+), 1 deletion(-) >>> In a support case we found a system with 40:00 as a schedule in a backup >>> job. It is possible to entire this calendar event on the web UI. >>> After this series the web UI won't allow it anymore with an error: >>> ``` >>> Parameter verification failed. (400) >>> schedule: invalid format - invalid calendar event '40:00' - unable to parse >>> calendar event at ':00' - Nom(Eof) >>> ``` >>> >> >> but that is a valid calendar spec? it just means something different than what >> the user expected ? (every hour at minute 40) > > At least systemd-analyze does not like it: > > ``` > systemd-analyze calendar 40:00 > Failed to parse calendar specification '40:00': Invalid argument > ``` > ok fair point > I would hope that 20:00 is no different than 40:00 (e.g. the first > component refers to hours). Is the "calendar spec" defined somewhere? > we have this: https://pbs.proxmox.com/docs/calendarevents.html which actually supports your change (hours not optional in the timespec) i just fear that some people already have configures such jobs that will not run anymore after this change? _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel