From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3041D1FF185 for ; Mon, 4 Aug 2025 13:47:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B92C71F631; Mon, 4 Aug 2025 13:49:00 +0200 (CEST) Message-ID: <60d95852-a9a0-46bf-8ee6-787457a56dc0@proxmox.com> Date: Mon, 4 Aug 2025 13:48:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Shannon Sterz References: <20250804105024.117020-1-s.sterz@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20250804105024.117020-1-s.sterz@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754308118960 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] fix #6599: ui: use font-awesome instead of png icons X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 04.08.25 um 12:50 PM schrieb Shannon Sterz: > previously we used custom png rendered icons for guests and storages > in the add menu of a pool, as well as for mountpoints for containers. > these appeared blurry on high resolution displays and since they were > just the same as the font-awesome icons anyway, use those directly. > the ui already loads font-awesome regardless, so there are no > down-sides here. > > Signed-off-by: Shannon Sterz > --- > www/manager6/grid/PoolMembers.js | 4 ++-- > www/manager6/lxc/Resources.js | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js > index f025a1380..83046ee0e 100644 > --- a/www/manager6/grid/PoolMembers.js > +++ b/www/manager6/grid/PoolMembers.js > @@ -243,7 +243,7 @@ Ext.define('PVE.grid.PoolMembers', { > items: [ > { > text: gettext('Virtual Machine'), > - iconCls: 'pve-itype-icon-qemu', > + iconCls: 'fa fa-desktop', > handler: function () { > var win = Ext.create('PVE.pool.AddVM', { pool: me.pool }); > win.on('destroy', reload); > @@ -252,7 +252,7 @@ Ext.define('PVE.grid.PoolMembers', { > }, > { > text: gettext('Storage'), > - iconCls: 'pve-itype-icon-storage', > + iconCls: 'fa fa-hdd-o', > handler: function () { > var win = Ext.create('PVE.pool.AddStorage', { pool: me.pool }); > win.on('destroy', reload); > diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js > index 9f6df3a58..3defb8003 100644 > --- a/www/manager6/lxc/Resources.js > +++ b/www/manager6/lxc/Resources.js > @@ -128,7 +128,7 @@ Ext.define('PVE.lxc.RessourceView', { > rows[confid] = { > group: group, > order: i, > - tdCls: 'pve-itype-icon-storage', > + iconCls: 'hdd-o', This changes from 'tdCls' to 'iconCls' and does not use 'fa fa-hdd-o' like above. Is that intentional? > editor: mpeditor, > header: header, > renderer: Ext.htmlEncode, Can we get rid of the related CCS classes and PNG images after this change? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel