From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2EBC21FF13A for ; Wed, 15 Apr 2026 10:21:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0741C80E7; Wed, 15 Apr 2026 10:21:55 +0200 (CEST) Message-ID: <602913e6-2190-44bf-b1ed-959dfd094526@proxmox.com> Date: Wed, 15 Apr 2026 10:21:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v3 07/30] pbs-config: implement encryption key config handling To: Daniel Kral , =?UTF-8?Q?Michael_K=C3=B6ppl?= , pbs-devel@lists.proxmox.com References: <20260414125923.892345-1-c.ebner@proxmox.com> <20260414125923.892345-8-c.ebner@proxmox.com> <576f8999-1a20-417a-9c6d-ec79467661da@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776241202731 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QHVNJP6CHF5TOIPILXWHUAZR6BOP42FY X-Message-ID-Hash: QHVNJP6CHF5TOIPILXWHUAZR6BOP42FY X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/15/26 10:02 AM, Daniel Kral wrote: > On Wed Apr 15, 2026 at 8:48 AM CEST, Christian Ebner wrote: >> On 4/14/26 4:31 PM, Michael Köppl wrote: >>> 2 comments inline >>> >>> On Tue Apr 14, 2026 at 2:59 PM CEST, Christian Ebner wrote: >>>> + // lock to avoid race with key deletion >>>> + open_backup_lockfile(&key_lock_path, None, true)?; >>> >>> This needs to be assigned to a variable, no? Otherwise, the lock would >>> be immediately dropped. >> >> Oh, good catch! Indeed without this the lock would be immediately >> dropped, will be fixed. Thanks! >> > > Would it make sense to add a #[must_use = "..."] attribute [0] to > open_backup_lockfile() or even the BackupLockGuard in general or would > it be too strict here? Yes, adding it directly to `BackupLockGuard` makes the most sense here. And with that, only above currently unused location is reported. Will send a dedicated patch for this shortly, thanks!