all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: David Riley <d.riley@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH docs/manager/qemu-server v4 00/17] Add API and UI for custom CPU models
Date: Thu, 7 May 2026 09:14:49 +0200	[thread overview]
Message-ID: <5lzuttlpzjkwvne5oicicuvgdesmdnxiegw7vprz4kuhdafuts@4zstsvybw6e6> (raw)
In-Reply-To: <519f4203-a378-479f-a3ba-41d62bed672b@proxmox.com>

Hey David, thanks a lot for testing!

On Wed, May 06, 2026 at 04:31:05PM +0200, David Riley wrote:
> Thanks for the patch. This seems to be a nice addition.
> 
> I’ve tested the series and found a regression in the VM creation
> wizard. When creating a Windows guest with the 'Add additional drive
> for VirtIO drivers' checkbox enabled and an ISO Image is added,
> the creation fails with:
> 
> 'Parameter verification failed. (400) ide0:
> explicit media=cdrom is required for iso images'
> 
> Looking at the request payload, the 'media=cdrom' property is missing
> for the VirtIO ISO:
> 
>   Before: ide0: "sani:iso/virtio-win-0.1.271.iso,media=cdrom"
>   Now: ide0: "sani:iso/virtio-win-0.1.271.iso"
> 
I was able to reproduce this on a fresh PVE VM with pve-manager 9.1.10. 
The culprit is commit f196d28f on pve-manager, which moved the ISO 
selector to a new panel, but omitted the onGetValues hook that was 
adding media=cdrom. I confirmed the issue with Dominik and sent a patch
fixing it [0].

> I also noticed that the wizard now defaults to the IDE bus for disks
> instead of SCSI, when the Guest OS Type Microsoft Windows is selected.
> 
This came with commit 6be73bfe on pve-manager, which made some changes 
to the sorting priority of that field. I think this is intentional? 
Maybe @Dominik can confirm.
> 
> On 4/30/26 5:59 PM, Arthur Bied-Charreton wrote:
[...]

[0] https://lore.proxmox.com/pve-devel/20260507065517.237996-1-a.bied-charreton@proxmox.com/T/#u




      reply	other threads:[~2026-05-07  7:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 16:00 [PATCH docs/manager/qemu-server v4 00/17] Add API and UI for custom CPU models Arthur Bied-Charreton
2026-04-30 16:00 ` [PATCH pve-docs v4 01/17] qm: add anchor to "CPU Type" section Arthur Bied-Charreton
2026-05-07 10:34   ` Fiona Ebner
2026-04-30 16:00 ` [PATCH qemu-server v4 02/17] cpu config: rename CPU models config path variable Arthur Bied-Charreton
2026-05-07 10:57   ` Fiona Ebner
2026-04-30 16:00 ` [PATCH qemu-server v4 03/17] cpu flags: move cpu flags-related utilities to their own module Arthur Bied-Charreton
2026-05-07 11:15   ` Fiona Ebner
2026-04-30 16:00 ` [PATCH qemu-server v4 04/17] cpu flags: add helper querying CPU flags with nodes supporting them Arthur Bied-Charreton
2026-05-07 11:57   ` Fiona Ebner
2026-04-30 16:00 ` [PATCH qemu-server v4 05/17] cpu config: add helpers to lock and write config Arthur Bied-Charreton
2026-05-07 12:06   ` Fiona Ebner
2026-04-30 16:00 ` [PATCH qemu-server v4 06/17] cpu: register standard option for CPU format Arthur Bied-Charreton
2026-05-07 12:11   ` Fiona Ebner
2026-05-07 14:01     ` Arthur Bied-Charreton
2026-05-07 14:08       ` Fiona Ebner
2026-05-08  6:40         ` Arthur Bied-Charreton
2026-04-30 16:00 ` [PATCH qemu-server v4 07/17] cpu config: set 'type' field before writing Arthur Bied-Charreton
2026-05-07 12:24   ` Fiona Ebner
2026-05-08  7:48     ` Arthur Bied-Charreton
2026-04-30 16:01 ` [PATCH qemu-server v4 08/17] cpu flags: improve flags list returned by endpoint Arthur Bied-Charreton
2026-05-07 13:10   ` Fiona Ebner
2026-04-30 16:01 ` [PATCH pve-manager v4 09/17] api: add endpoint querying available CPU flags cluster-wide Arthur Bied-Charreton
2026-05-07 13:29   ` Fiona Ebner
2026-04-30 16:01 ` [PATCH pve-manager v4 10/17] api: add CRUD handlers for custom CPU models Arthur Bied-Charreton
2026-05-07 14:02   ` Fiona Ebner
2026-04-30 16:01 ` [PATCH pve-manager v4 11/17] ui: cpu model selector: allow filtering out custom models Arthur Bied-Charreton
2026-04-30 16:01 ` [PATCH pve-manager v4 12/17] ui: add basic custom CPU model editor Arthur Bied-Charreton
2026-04-30 16:01 ` [PATCH pve-manager v4 13/17] ui: cpu flags selector: add CPU flag editor for custom models Arthur Bied-Charreton
2026-04-30 16:01 ` [PATCH pve-manager v4 14/17] ui: cpu flags selector: fix buffered rendering error Arthur Bied-Charreton
2026-04-30 16:01 ` [PATCH pve-manager v4 15/17] ui: cpu flags selector: allow filtering out flags supported on 0 nodes Arthur Bied-Charreton
2026-04-30 16:01 ` [PATCH pve-manager v4 16/17] ui: cpu flags selector: add search bar for large lists of flags Arthur Bied-Charreton
2026-04-30 16:01 ` [PATCH pve-manager v4 17/17] RFC: ui: group custom CPU with resource mappings Arthur Bied-Charreton
2026-05-06 14:31 ` [PATCH docs/manager/qemu-server v4 00/17] Add API and UI for custom CPU models David Riley
2026-05-07  7:14   ` Arthur Bied-Charreton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5lzuttlpzjkwvne5oicicuvgdesmdnxiegw7vprz4kuhdafuts@4zstsvybw6e6 \
    --to=a.bied-charreton@proxmox.com \
    --cc=d.riley@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal