From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <p.hufnagl@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 11EE2B3263 for <pbs-devel@lists.proxmox.com>; Tue, 28 Nov 2023 15:49:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F1F8F19807 for <pbs-devel@lists.proxmox.com>; Tue, 28 Nov 2023 15:48:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Tue, 28 Nov 2023 15:48:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DBE8C41041 for <pbs-devel@lists.proxmox.com>; Tue, 28 Nov 2023 15:48:34 +0100 (CET) Message-ID: <5ffc199c-6357-4757-a96d-c1ce23b7a254@proxmox.com> Date: Tue, 28 Nov 2023 15:48:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pbs-devel@lists.proxmox.com References: <20231128143403.443330-1-p.hufnagl@proxmox.com> From: Philipp Hufnagl <p.hufnagl@proxmox.com> In-Reply-To: <20231128143403.443330-1-p.hufnagl@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v4 0/3] fix #4315: datastore: Exclude entries from sync X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 28 Nov 2023 14:49:09 -0000 As discussed off-list, this is patch is not release imminent for upcoming PBS 3.1 release. On 11/28/23 15:34, Philipp Hufnagl wrote: > This allows to use Group Filter for sync jobs so matches can not just be > included but also excluded. For this the "group-filter" configuration > syntax has been extended with an optional "behaviour" parameter. > this can be "include" or "exclude". First, all include filter will be > applied, then all exclude filter. If only include filter are set, > every group starts included. > > Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com> > --- > > Changes since v3: > * including all when only exclude filter are present > > Changes since v2: > * rebase to new master > * change docu as suggested > * make list for filter smaller > > Changes since v1: > * rename behaviour in behavior > * modify behavior, so that first all include filter will be executed, > then all exlude one > > > Philipp Hufnagl (3): > fix #4315: jobs: modify GroupFilter so include/exclude is tracked > ui: Show if Filter includes or excludes > docs: document new include/exclude paramenter > > docs/managing-remotes.rst | 13 ++ > pbs-api-types/src/datastore.rs | 11 +- > pbs-api-types/src/jobs.rs | 64 +++++++-- > src/api2/pull.rs | 11 +- > src/api2/tape/backup.rs | 17 ++- > src/server/pull.rs | 23 +++- > www/form/GroupFilter.js | 233 ++++++++++++++++++++++++--------- > 7 files changed, 281 insertions(+), 91 deletions(-) >