From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C561F1FF0B2 for ; Mon, 24 Aug 2026 16:38:22 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 44E1521648; Mon, 24 Aug 2026 16:38:12 +0200 (CEST) Message-ID: <5fbd16aa-3133-4ac0-bd04-b9773da69760@proxmox.com> Date: Mon, 24 Aug 2026 16:38:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH guest-common v3 1/1] helpers: exec hookscript: add optional parameters To: Dominik Csapak , pve-devel@lists.proxmox.com References: <20260227120728.2152303-1-d.csapak@proxmox.com> <20260227120728.2152303-2-d.csapak@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260227120728.2152303-2-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787582258318 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.834 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JFFTBH57Y53WVE7OZRSL6IT4E7KRNLLT X-Message-ID-Hash: JFFTBH57Y53WVE7OZRSL6IT4E7KRNLLT X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 27.02.26 um 1:07 PM schrieb Dominik Csapak: > sometimes we may want to call the hookscript with additional parameters > in some phases, e.g. we want to call it for each pci device that was > prepared before starting with the correct uuid or pci id. > > Add these new parameters to the environment instead of the positional > parameters of the hookscript, since that is more future proof and we get > a key/value pair instead of just the position. > > Use the prefix 'PVE_HOOK_' so they're always in a separate namespace. > > Signed-off-by: Dominik Csapak Reviewed-by: Fiona Ebner > --- > src/PVE/GuestHelpers.pm | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/GuestHelpers.pm b/src/PVE/GuestHelpers.pm > index f8d112b..1536259 100644 > --- a/src/PVE/GuestHelpers.pm > +++ b/src/PVE/GuestHelpers.pm > @@ -115,14 +115,23 @@ sub check_hookscript { > } > > sub exec_hookscript { > - my ($conf, $vmid, $phase, $stop_on_error) = @_; > + my ($conf, $vmid, $phase, $stop_on_error, $params) = @_; > > return if !$conf->{hookscript}; > > + $params //= {}; > + > eval { > my $hookscript = check_hookscript($conf->{hookscript}); > die $@ if $@; > > + local %ENV; > + > + for my $key (keys $params->%*) { > + my $new_key = "PVE_HOOK_" . uc($key); > + $ENV{$new_key} = $params->{$key}; > + } > + > PVE::Tools::run_command([$hookscript, $vmid, $phase]); > }; > if (my $err = $@) {