From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <g.goller@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id C55F89ABC7
for <pbs-devel@lists.proxmox.com>; Mon, 16 Oct 2023 11:51:33 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id A758215C51
for <pbs-devel@lists.proxmox.com>; Mon, 16 Oct 2023 11:51:33 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Mon, 16 Oct 2023 11:51:31 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3FA8540EA5
for <pbs-devel@lists.proxmox.com>; Mon, 16 Oct 2023 11:51:31 +0200 (CEST)
Message-ID: <5f00418c-adfe-4e4a-8f5c-8e0b80e1ff1c@proxmox.com>
Date: Mon, 16 Oct 2023 11:51:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Dominik Csapak <d.csapak@proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
References: <20230913142045.240835-1-g.goller@proxmox.com>
<bc2a187c-aa42-4fa8-967f-02b15ac23097@proxmox.com>
<9912014b-0ad8-4cf8-9ce7-8b46a553b55b@proxmox.com>
<83b3341d-9b14-4c0d-9265-65fb9d95dcfe@proxmox.com>
<92df7c1a-2691-4971-93a8-22bc9d260ed8@proxmox.com>
<87356f09-673e-4ae8-ba0a-9cedc30e5572@proxmox.com>
Content-Language: en-US
From: Gabriel Goller <g.goller@proxmox.com>
In-Reply-To: <87356f09-673e-4ae8-ba0a-9cedc30e5572@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.333 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 16 Oct 2023 09:51:33 -0000
On 10/13/23 15:04, Dominik Csapak wrote:
> [..]
>
>
>> Having something like "Running" as text here would be nice, but we
>> cannot just use a `.x-grid-row-loading:after { content: 'Running' }`
>> as that misses translations.
>>
>> One option would be to avoid ExtJS CSS here and use font-awesome like
>> "fa fa-fw fa-circle-o-notch fa-spin", the only disadvantage from that
>> is that we lose the site-wide synced animation that the currently used
>> GIF provides, can be worked around but IIRC there's nothing native
>> available for doing so.
>
> we could also create our own class that uses the gif as a background
> image, or
> simply embed the gif directly? then we'd keep the image and could still
> add a translated text
To be honest, I wouldn't add a text. We would have to separate between
'Running'
and 'Loading', because that's not the same thing (e.g., in pbs we use
the spinner
on the snapshot size—where it would be 'Loading'—and on the task
log—where it would
be 'Running'). Then we would also have to adjust some tables, because
the 'Running'
or 'Loading' text won't fit (As far as I know, they use a fixed width).
>> For now the adapted CSS would be an OK stop-gap, IIRC we only use such
>> grid loading classes for such scheduled-job grids. Adding it to PVE
>> (isn't there even anything besides replication using that?) would be
>> good too though. IMO no need for widget toolkit, I'd keep this contained
>> for now.
>
> we use that for running tasks and replication, and the class
> 'x-grid-row-loading' is the same for pve/pmg/pbs (so i thought it might
> warrant to have it in widget toolkit, so that we can remove it from the
> individual projects' css files)
>
Right, we can do that, should be a fairly simple change as well.