From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E4A921FF15C for ; Wed, 19 Feb 2025 17:13:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9FD112EFFE; Wed, 19 Feb 2025 17:13:32 +0100 (CET) Message-ID: <5ef491f7-0a5e-4cbb-905f-ce446c87c1c6@proxmox.com> Date: Wed, 19 Feb 2025 17:12:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Stefan Hanreich To: Proxmox VE development discussion , Maximiliano Sandoval References: <20250219100949.54413-1-s.hanreich@proxmox.com> <72f66ab3-857c-466a-b73e-fa881195de7c@proxmox.com> Content-Language: en-US In-Reply-To: <72f66ab3-857c-466a-b73e-fa881195de7c@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.656 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-ve-rs 1/1] partially fix #6176: config: guest: change default for firewall key X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 2/19/25 15:25, Stefan Hanreich wrote: >> Why not use `#[serde(default)]` and always get a boolean? The only place >> it is used uses .unwrap_or(false) (unwrap_or_default would be preferable >> imho). > > The reasoning for this is that it is modeled 1:1 after what's in the > property string. It works when reading, but when trying to serialize the > struct you then always have to provide the value for firewall and cannot > omit it. Nvm, it should actually work - for some reason I thought it was Some(false) and not None then. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel