From: Fiona Ebner <f.ebner@proxmox.com>
To: "Michael Köppl" <m.koeppl@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server v5 4/7] api: record VM ID as used on creation, cloning, and destruction
Date: Tue, 22 Sep 2026 16:33:30 +0200 [thread overview]
Message-ID: <5eb6b7f4-2810-4d76-a7af-aeb7cf821154@proxmox.com> (raw)
In-Reply-To: <20260921155410.938337-5-m.koeppl@proxmox.com>
Am 21.09.26 um 5:54 PM schrieb Michael Köppl:
> @@ -6708,6 +6721,11 @@ __PACKAGE__->register_method({
>
> PVE::Cluster::check_cfs_quorum();
>
> + # remote migration brings in a VMID this cluster has not seen,
> + # so record it here
Style nit: comment would fit on one line
(same in the next patch)
> + eval { PVE::UsedGuestIDs::add_id($vmid) };
> + die "unable to create VM $vmid - could not record VMID as used - $@" if $@;
> +
> my $lock = 'create';
> eval { PVE::QemuConfig->create_and_lock_config($vmid, 0, $lock); };
>
next prev parent reply other threads:[~2026-09-22 14:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 15:54 [PATCH many v5 0/7] add option to prevent suggesting previously used VMIDs Michael Köppl
2026-09-21 15:54 ` [PATCH pve-cluster v5 1/7] cluster files: add used-guest-ids Michael Köppl
2026-09-22 14:22 ` Fiona Ebner
2026-09-21 15:54 ` [PATCH pve-cluster v5 2/7] datacenter config: add unique-next-id to schema Michael Köppl
2026-09-22 14:22 ` Fiona Ebner
2026-09-22 14:43 ` Michael Köppl
2026-09-23 7:48 ` Fiona Ebner
2026-09-23 8:01 ` Fiona Ebner
2026-09-23 8:18 ` Fiona Ebner
2026-09-21 15:54 ` [PATCH pve-guest-common v5 3/7] add module to track previously used guest IDs Michael Köppl
2026-09-22 14:22 ` Fiona Ebner
2026-09-22 15:55 ` Michael Köppl
2026-09-23 7:52 ` Fiona Ebner
2026-09-21 15:54 ` [PATCH qemu-server v5 4/7] api: record VM ID as used on creation, cloning, and destruction Michael Köppl
2026-09-22 14:33 ` Fiona Ebner [this message]
2026-09-21 15:54 ` [PATCH pve-container v5 5/7] api: record CT " Michael Köppl
2026-09-21 15:54 ` [PATCH pve-manager v5 6/7] close #4369: api: optionally only suggest unique IDs Michael Köppl
2026-09-22 14:33 ` Fiona Ebner
2026-09-21 15:54 ` [PATCH pve-manager v5 7/7] close #4369: ui: add datacenter option for unique VM/CT IDs Michael Köppl
2026-09-22 15:02 ` [PATCH many v5 0/7] add option to prevent suggesting previously used VMIDs Fiona Ebner
2026-09-23 8:13 ` Fiona Ebner
2026-09-23 14:10 ` Michael Köppl
2026-09-23 15:56 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eb6b7f4-2810-4d76-a7af-aeb7cf821154@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.