From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8B06F1FF185 for ; Mon, 21 Jul 2025 15:37:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7DE16101FE; Mon, 21 Jul 2025 15:39:03 +0200 (CEST) Message-ID: <5c358be9-8199-4f56-8dea-8da6902ee0ae@proxmox.com> Date: Mon, 21 Jul 2025 15:38:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Hannes Laimer References: <20250719125035.9926-1-c.ebner@proxmox.com> <20250719125035.9926-21-c.ebner@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753105131702 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v9 17/46] verify: implement chunk verification for stores with s3 backend X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: pbs-devel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 7/21/25 3:36 PM, Hannes Laimer wrote: > On Sat Jul 19, 2025 at 2:50 PM CEST, Christian Ebner wrote: >> For datastores backed by an S3 compatible object store, rather than >> reading the chunks to be verified from the local filesystem, fetch >> them via the s3 client from the configured bucket. >> > > Could we somehow take advantage of the hash S3 provides for objects[1]? > We can't use our hashes tough, so not if how we would... > > [1] https://docs.aws.amazon.com/AmazonS3/latest/userguide/checking-object-integrity.html > This is actually on my todo list, the issue here is that not all s3 backends implement the checksuming as required. and for encrypted we would need the crc checksums. That is why for now this does not use these values, but rather the regular download and check logic. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel