From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7A1096ACAB for <pbs-devel@lists.proxmox.com>; Wed, 9 Dec 2020 10:32:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5F38AE796 for <pbs-devel@lists.proxmox.com>; Wed, 9 Dec 2020 10:32:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4F753E78A for <pbs-devel@lists.proxmox.com>; Wed, 9 Dec 2020 10:32:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1114844825 for <pbs-devel@lists.proxmox.com>; Wed, 9 Dec 2020 10:32:28 +0100 (CET) To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Dietmar Maurer <dietmar@proxmox.com>, Hannes Laimer <h.laimer@proxmox.com> References: <20201209084257.72850-1-h.laimer@proxmox.com> <1493873668.1116.1607504621900@webmail.proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <5b8c2262-b6c6-09f5-d224-f6f95a1b38d7@proxmox.com> Date: Wed, 9 Dec 2020 10:32:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 MIME-Version: 1.0 In-Reply-To: <1493873668.1116.1607504621900@webmail.proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.069 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-client.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup] add inspection in proxmox-backup-manager for .blob, .didx and .fidx files X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 09 Dec 2020 09:32:59 -0000 On 09.12.20 10:03, Dietmar Maurer wrote: >> On 12/09/2020 9:42 AM Hannes Laimer <h.laimer@proxmox.com> wrote: =2E.. >> +pub fn inspect_commands() -> CommandLineInterface { >> + >> + let cmd_def =3D CliCommandMap::new() >> + .insert("blob",CliCommand::new(&API_METHOD_INSPECT_BLOB)) >> + .insert("fidx",CliCommand::new(&API_METHOD_INSPECT_FIXED_INDE= X)) >> + .insert("didx",CliCommand::new(&API_METHOD_INSPECT_DYNAMIC_IN= DEX)); >=20 > Can't we autodetect the file type? >=20 proxmox-backup-client.rs has a 'parse_archive_type' function we maybe can= reuse here, it's used there when passing an "archive-name" on restore.