From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <c.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 1B3F8931F4
for <pbs-devel@lists.proxmox.com>; Mon, 8 Apr 2024 15:36:19 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id EFE7BBA52
for <pbs-devel@lists.proxmox.com>; Mon, 8 Apr 2024 15:36:18 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Mon, 8 Apr 2024 15:36:18 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 15728440FF
for <pbs-devel@lists.proxmox.com>; Mon, 8 Apr 2024 15:36:18 +0200 (CEST)
Message-ID: <5af3c128-2b67-464d-afa3-79536fa99ebf@proxmox.com>
Date: Mon, 8 Apr 2024 15:36:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>,
=?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
References: <20240328123707.336951-1-c.ebner@proxmox.com>
<20240328123707.336951-42-c.ebner@proxmox.com>
<1712242388.ynphk5rlc1.astroid@yuna.none>
Content-Language: en-US, de-DE
From: Christian Ebner <c.ebner@proxmox.com>
In-Reply-To: <1712242388.ynphk5rlc1.astroid@yuna.none>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.031 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 41/58] specs: add backup
detection mode specification
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 08 Apr 2024 13:36:19 -0000
On 4/4/24 16:54, Fabian Grünbichler wrote:
> On March 28, 2024 1:36 pm, Christian Ebner wrote:
>> Adds the specification for switching the detection mode used to
>> identify regular files which changed since a reference backup run.
>>
>> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>> ---
>> changes since version 2:
>> - removed unneeded vector storing archive names for which to enable
>> metadata mode, set either for all or none
>>
>> pbs-client/src/backup_specification.rs | 40 ++++++++++++++++++++++++++
>> 1 file changed, 40 insertions(+)
>>
>> diff --git a/pbs-client/src/backup_specification.rs b/pbs-client/src/backup_specification.rs
>> index 619a3a9da..4b1dbd188 100644
>> --- a/pbs-client/src/backup_specification.rs
>> +++ b/pbs-client/src/backup_specification.rs
>> @@ -4,6 +4,7 @@ use proxmox_schema::*;
>>
>> const_regex! {
>> BACKUPSPEC_REGEX = r"^([a-zA-Z0-9_-]+\.(pxar|img|conf|log)):(.+)$";
>> + DETECTION_MODE_REGEX = r"^(data|metadata(:[a-zA-Z0-9_-]+\.pxar)*)$";
>
> this
>
>> }
>>
>> pub const BACKUP_SOURCE_SCHEMA: Schema =
>> @@ -11,6 +12,11 @@ pub const BACKUP_SOURCE_SCHEMA: Schema =
>> .format(&ApiStringFormat::Pattern(&BACKUPSPEC_REGEX))
>> .schema();
>>
>> +pub const BACKUP_DETECTION_MODE_SPEC: Schema =
>> + StringSchema::new("Backup source specification ([data|metadata(:<label>,...)]).")
>
> and this
>
>> + .format(&ApiStringFormat::Pattern(&DETECTION_MODE_REGEX))
>> + .schema();
>> +
>> pub enum BackupSpecificationType {
>> PXAR,
>> IMAGE,
>> @@ -45,3 +51,37 @@ pub fn parse_backup_specification(value: &str) -> Result<BackupSpecification, Er
>>
>> bail!("unable to parse backup source specification '{}'", value);
>> }
>> +
>> +/// Mode to detect file changes since last backup run
>> +pub enum BackupDetectionMode {
>> + /// Regular mode, re-encode payload data
>> + Data,
>> + /// Compare metadata, reuse payload chunks if metadata unchanged
>> + Metadata,
>
> and this now do not really match anymore?
>
Yes, removed the leftover complexity of the regex for the upcoming version