From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BC1191FF15C for ; Fri, 14 Nov 2025 11:45:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E6540DD97; Fri, 14 Nov 2025 11:46:33 +0100 (CET) Message-ID: <5a731352-1f77-4b15-9a22-7064b70ce519@proxmox.com> Date: Fri, 14 Nov 2025 11:46:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Nicolas Frey References: <20251113093118.195229-1-n.frey@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20251113093118.195229-1-n.frey@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763117164721 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.352 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible spam tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} v4 00/12] parallelize chunk reads in verification X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Gave this another spin, looks good to me apart from the commit tag ordering. Some additional ballpark benchmark figures from my testing: Used for tests: echo 3 > /proc/sys/vm/drop_caches && time proxmox-backup-manager verify --read-threads 1 --verify-threads 4 --ignore-verified false S3 store backed by Ceph RGW (6365 chunks with total 10.907 GiB, 42 index files) ------------------------------- #threads | #threads | runtime ------------------------------- read: 1 | verify: 4 | 168s read: 1 | verify: 8 | 166s read: 2 | verify: 4 | 89s read: 4 | verify: 4 | 50s read: 8 | verify: 4 | 32s read: 16 | verify: 4 | 26s read: 32 | verify: 4 | 25s read: 8 | verify: 8 | 30s read: 16 | verify: 8 | 23s read: 32 | verify: 8 | 23s read: 8 | verify: 16 | 30s read: 16 | verify: 16 | 23s read: 16 | verify: 32 | 23s read: 32 | verify: 32 | 23s so above 8 verify threads CPU bound, below 16 read threads IO bound. Regular datastore on NVME SSD (6012 chunks with total 8.059 GiB, 37 index files) ------------------------------- #threads | #threads | runtime ------------------------------- read: 1 | verify: 4 | 11s read: 1 | verify: 8 | 9s read: 2 | verify: 4 | 9s read: 4 | verify: 4 | 8s read: 8 | verify: 4 | 8s read: 16 | verify: 4 | 8s read: 32 | verify: 4 | 9s read: 8 | verify: 8 | 6s read: 16 | verify: 8 | 6s read: 32 | verify: 8 | 6s read: 8 | verify: 16 | 5s read: 16 | verify: 16 | 6s read: 16 | verify: 32 | 6s read: 32 | verify: 32 | 6s so mostly CPU bound. With the comments on the doc patch addressed, consider: Reviewed-by: Christian Ebner Tested-by: Christian Ebner _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel