From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <MHonkoop@comsolve.nl>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 408296085E
 for <pve-devel@lists.proxmox.com>; Tue, 15 Dec 2020 00:12:54 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 2D149BE6B
 for <pve-devel@lists.proxmox.com>; Tue, 15 Dec 2020 00:12:24 +0100 (CET)
Received: from h01p01.smtp.routit.net (h01p01.smtp.routit.net [89.146.30.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 238A4BE54
 for <pve-devel@lists.proxmox.com>; Tue, 15 Dec 2020 00:12:22 +0100 (CET)
Authentication-Results: h01p01.smtp.routit.net;
 spf=Pass smtp.mailfrom=MHonkoop@comsolve.nl
Received-SPF: Pass (h01p01.smtp.routit.net: domain of
 MHonkoop@comsolve.nl designates 185.106.153.121 as permitted
 sender) identity=mailfrom; client-ip=185.106.153.121;
 receiver=h01p01.smtp.routit.net;
 envelope-from="MHonkoop@comsolve.nl";
 x-sender="MHonkoop@comsolve.nl"; x-conformance=spf_only;
 x-record-type="v=spf1"; x-record-text="v=spf1
 +a:mail.comsolve.nl +include:heldenvan.nu -all"
IronPort-SDR: 2MntjaA2Y5r1qDrECw2DuXQiNjlgSpOeshC1CkdjFvp7CmabpJgBKDD5GADAMqkXolu1BaA2dM
 jEBROTG0pPPA==
X-SenderBaseSpam: None
Received: from mail.comsolve.nl ([185.106.153.121])
 by h01p01.smtp.routit.net with ESMTP; 15 Dec 2020 00:12:15 +0100
Received: from DOM_COMSOLVE-MTA by mail.comsolve.nl
 with Novell_GroupWise; Tue, 15 Dec 2020 00:12:15 +0100
Message-Id: <5FD7F14A0200008800004144@mail.comsolve.nl>
X-Mailer: Novell GroupWise Internet Agent 14.2.2 
Date: Tue, 15 Dec 2020 00:12:10 +0100
From: "Michael Honkoop" <MHonkoop@comsolve.nl>
To: <pve-devel@lists.proxmox.com>
References: <5FD56B860200008800004138@mail.comsolve.nl>
 <5FD56B860200008800004138@mail.comsolve.nl>
 <1607929849.0i4pachlbl.astroid@nora.none>
In-Reply-To: <1607929849.0i4pachlbl.astroid@nora.none>
Mime-Version: 1.0
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.114 Adjusted score from AWL reputation of From: address
 HTML_MESSAGE            0.001 HTML included in message
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 KAM_LOTSOFHASH           0.25 Emails with lots of hash-like gibberish
 RCVD_IN_DNSWL_LOW        -0.7 Sender listed at https://www.dnswl.org/,
 low trust RCVD_IN_MSPIKE_H3       -0.01 Good reputation (+3)
 RCVD_IN_MSPIKE_WL       -0.01 Mailspike good senders
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [pve-devel] Feature: OAuth / OpenID-connect implementation
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 14 Dec 2020 23:12:54 -0000

Hi Fabian,

Thanks for your hints regarding where to find the realm types,
researching further on my issue.

best regards, 

Michael Honkoop

>>> Fabian Grünbichler <f.gruenbichler@proxmox.com> 8:12 14-12-2020
>>>
On December 13, 2020 2:16 am, Michael Honkoop wrote:
> Hi all, 
> 
> I am slowly working on implementing the authentication method/ entry
fields for it  in PVE, which have shown up, and look to be fine (at
first glance).
> 
> There are 2 things i am yes unable to grasp, and i hope you could
give me some directions : 
> 
> 1)
> UI : 
> As Oauth/OpenID-connect does not have a need for a field 'tfa', but
its inherited from the common auth, i'd like to override it ( as in not
visible)
> 
> 2)
> Schema: 
> I cant seem to get where a/the schema is defined, or updated for that
matter.
> I mean i have the UI / auth on the dc level now showing an entry and
when i select add it will spawn the dialog to input parameters.
> However if i were to put some text in there and click add it spawns
an errormessage 'Parameter verification failed. (400)', 'type: value
'oauth' does not have a value in the enumeration 'ad, ldap, pam, pve''
and 'property is not defined in schema and the schema does not allow
additional properties'
> 
> i've been searching where i can define it but this still have not
found, or better said due to my newness in this i'm not following where
it is/should be defined.

the possible realm types are defined here:

https://git.proxmox.com/?p=pve-access-control.git;a=blob;f=PVE/API2/Domains.pm;h=9c2b2548028790f19baaa81bde4cf0f071bb7719;hb=HEAD#l86

https://git.proxmox.com/?p=pve-access-control.git;a=blob;f=PVE/Auth/Plugin.pm;h=141305336c8640dd40879eb6e084b95c51ad0fa7;hb=HEAD

https://git.proxmox.com/?p=pve-access-control.git;a=tree;f=PVE/Auth;h=935646bae7647759c8b9ac04881275affb184500;hb=HEAD


each type registers as a plugin in the SectionConfig (which is in 
pve-common), the add/update/delete schemas are generated from the
plugin 
definitions.

> 
> best regards, 
> 
> Michael Honkoop
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

> 
> 
> 


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel