From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1FBC091568 for <pve-devel@lists.proxmox.com>; Wed, 1 Feb 2023 12:39:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ED0982EE02 for <pve-devel@lists.proxmox.com>; Wed, 1 Feb 2023 12:38:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Wed, 1 Feb 2023 12:38:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C424A459FF for <pve-devel@lists.proxmox.com>; Wed, 1 Feb 2023 12:38:28 +0100 (CET) Message-ID: <58bff4b4-c4cf-3f0c-95fb-c580d0bde6dc@proxmox.com> Date: Wed, 1 Feb 2023 12:38:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:110.0) Gecko/20100101 Thunderbird/110.0 Content-Language: en-GB, de-AT To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Leo Nunner <l.nunner@proxmox.com> References: <20230130105953.126483-1-l.nunner@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20230130105953.126483-1-l.nunner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH v2 manager] fix #4481: fetch changelogs for any Proxmox repository X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 01 Feb 2023 11:39:00 -0000 Am 30/01/2023 um 11:59 schrieb Leo Nunner: > This patch fixes the issue that when the user supplied any non-standard > repositories, the changelogs often wouldn't load. For example, providing > both pve-no-subscription and pbs-no-subscription broke the changelog > API, since the URL built for pbs-no-subscription was invalid. > > Signed-off-by: Leo Nunner <l.nunner@proxmox.com> > --- > Changes from v1: > - Directly pass $pkgfile to get_changelog_url > - Only check enabled repositories > - Compare the site of the package with the repository URL > > PVE/API2/APT.pm | 28 +++++++++++++++++++++------- > 1 file changed, 21 insertions(+), 7 deletions(-) > > applied, thanks! with a few (mostly unrelated to this patch) cleanups in the module and a comment for why passing "pve" to the Proxmox::RS::APT::Repositories::repositories is done and that we actually check all configured repos not only PVE specific,