From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 453021FF183 for ; Wed, 30 Jul 2025 16:36:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B84DC11766; Wed, 30 Jul 2025 16:37:28 +0200 (CEST) Message-ID: <5840fe2e-b42d-47ca-9078-5487e7050168@proxmox.com> Date: Wed, 30 Jul 2025 16:37:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pbs-devel@lists.proxmox.com References: <20250729165655.681368-1-s.hanreich@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20250729165655.681368-1-s.hanreich@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.702 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lexer.rs, proxmox-backup-api.rs, mod.rs, helper.rs, proxmox-backup-manager.rs, config.rs, network.rs, rrd.rs, proxmox-backup-proxy.rs, lib.rs, proxmox.com, parser.rs] Subject: [pbs-devel] superseded: [PATCH proxmox{-ve-rs, , -backup, -firewall, -network-interface-pinning} 0/8] proxmox-network-interface-pinning X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" https://lore.proxmox.com/pbs-devel/20250730141550.281340-1-s.hanreich@proxmox.com/T/#t On 7/29/25 6:56 PM, Stefan Hanreich wrote: > Introduce the proxmox-network-interface-pinning tool for PBS, written in Rust. > > I basically had to do the same changes to the network stack in PBS, that I > already had to do for Proxmox VE: > > * use ip link for determining physical interfaces in the network configuration > stack > * move metric collection over to this new method as well > > In the process I moved the existing functions for querying 'ip link', that were > already used by the firewall, to proxmox-network-api which seems like a better > fit than proxmox-ve-config (which was only a temporary solution anyway). > > I also decided to move PBS over to the implementations contained in > proxmox-network-api, but if this is considered too drastic a change so close to > a release (I'm torn myself), then it should be trivial to revert those changes > and implement / copy-paste everything to the respective projects instead. > > PBS does not automatically apply pending changes on reboot. It is already agreed > with @Thomas, that he will add a respective service to the PBS repository. > > proxmox-backup depends on proxmox-network-api > proxmox-firewall depends on proxmox-network-api > proxmox-network-interface-pinning depends on proxmox-network-api > > proxmox-ve-rs: > > Stefan Hanreich (1): > host: network: move to proxmox-network-api > > proxmox-ve-config/src/host/mod.rs | 1 - > proxmox-ve-config/src/host/network.rs | 35 --------------------------- > 2 files changed, 36 deletions(-) > delete mode 100644 proxmox-ve-config/src/host/network.rs > > > proxmox: > > Stefan Hanreich (3): > pbs-api-types: use proxmox-network-api types > proxmox-network-api: use ip link for querying interface information > network-api: add rename_interfaces method > > Cargo.toml | 1 + > pbs-api-types/src/network.rs | 345 ----------------------- > proxmox-network-api/Cargo.toml | 2 + > proxmox-network-api/debian/control | 8 +- > proxmox-network-api/src/api_types.rs | 8 +- > proxmox-network-api/src/config/helper.rs | 158 +++++++---- > proxmox-network-api/src/config/mod.rs | 72 ++++- > proxmox-network-api/src/config/parser.rs | 37 ++- > 8 files changed, 206 insertions(+), 425 deletions(-) > delete mode 100644 pbs-api-types/src/network.rs > > > proxmox-backup: > > Stefan Hanreich (2): > config: network: move to proxmox-network-api > metric_collection: use ip link for determining the type of interfaces > > Cargo.toml | 5 + > debian/control | 1 + > pbs-config/src/lib.rs | 10 +- > pbs-config/src/network/helper.rs | 223 ----- > pbs-config/src/network/lexer.rs | 136 --- > pbs-config/src/network/mod.rs | 687 --------------- > pbs-config/src/network/parser.rs | 846 ------------------- > src/api2/node/network.rs | 13 +- > src/bin/proxmox-backup-api.rs | 3 +- > src/bin/proxmox-backup-manager.rs | 1 + > src/bin/proxmox-backup-proxy.rs | 1 + > src/bin/proxmox_backup_manager/network.rs | 14 +- > src/server/metric_collection/mod.rs | 87 +- > src/server/metric_collection/pull_metrics.rs | 5 +- > src/server/metric_collection/rrd.rs | 5 +- > 15 files changed, 112 insertions(+), 1925 deletions(-) > delete mode 100644 pbs-config/src/network/helper.rs > delete mode 100644 pbs-config/src/network/lexer.rs > delete mode 100644 pbs-config/src/network/mod.rs > delete mode 100644 pbs-config/src/network/parser.rs > > > proxmox-firewall: > > Stefan Hanreich (1): > firewall: config: use proxmox-network-api > > proxmox-firewall/Cargo.toml | 3 ++- > proxmox-firewall/src/config.rs | 29 +++++---------------- > proxmox-firewall/tests/integration_tests.rs | 8 +++--- > 3 files changed, 12 insertions(+), 28 deletions(-) > > > proxmox-network-interface-pinning: > > Stefan Hanreich (1): > initial commit > > > Summary over all repositories: > 28 files changed, 330 insertions(+), 2414 deletions(-) > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel