From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 1BE271FF0E9 for ; Thu, 16 Jul 2026 14:23:36 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D7C672140A; Thu, 16 Jul 2026 14:23:34 +0200 (CEST) Message-ID: <581c5a4a-01a0-43c1-bc2b-7123923fe335@proxmox.com> Date: Thu, 16 Jul 2026 14:23:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server] debian: add maintscript to remove unused file To: Maximiliano Sandoval , pve-devel@lists.proxmox.com References: <20260320135120.372074-1-m.sandoval@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260320135120.372074-1-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784204591801 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.236 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FNFXTNYOPB6ATJD2KWSTBGTISYOVNMFD X-Message-ID-Hash: FNFXTNYOPB6ATJD2KWSTBGTISYOVNMFD X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 20.03.26 um 2:51 PM schrieb Maximiliano Sandoval: > The conffile was moved to LIDBIR in in 4093c3f4a but there was no > associated cleanup. > > If one starts from a version of Proxmox VE older than 9, then the the > configuration would be at /etc. If the machine is then updated to > version 9, then both versions will be present, with the version at /etc > having a higher priority as per modules-load.d(5). In such a case, any > changes made in the packaged configuration will be ignored. > > The rm_config (see dpkg-maintscript-helper(1)) is used to remove the > trailing config if it was not touched by the user. If the file was > touched by the user then it is automatically moved and we move it back > manually so that it continues to have higher preference. > > Suggested-by: Fabian Grünbichler > Signed-off-by: Maximiliano Sandoval The versions need to be adapted to match the next qemu-server version bump. With that: Reviewed-by: Fiona Ebner One more comment inline: > --- > > Notes: > Tested: > > 1. Created pve 8 VM using the 8.4 iso > 2. Checked the version at /etc is present > 3. Updated to pve 9 > 4. Checked that both versions are present > 5. Updated the qemu-server package using this patch > 6. Verified the file at /etc is not there > > During step 5. the following message can be seen: > > Removing obsolete conffile /etc/modules-load.d/qemu-server.conf ... > > If we edit the file before 5. then one would see > > Obsolete conffile /etc/modules-load.d/qemu-server.conf has been modified by you. > Saving as /etc/modules-load.d/qemu-server.conf.dpkg-bak ... > Moving qemu-server.conf.dpkg-bak back to qemu-server.conf > > and systemd-delta would still consider this as an override of the > version at /usr/lib. > > Further reinstalls of the qemu-server package will leave alone this > version of /etc/modules-load.d/qemu-server.conf. > > Note that the version at /etc will only have a higher preference over > the one at /usr/lib if it is named exactly the same, thus we move it > back rather than renaming it to, e.g. qemu-server-old.conf, as this > would result in the union of both modules being loaded by > systemd-modules-load.service at boot. > > debian/postinst | 18 ++++++++++++++++++ > debian/qemu-server.maintscript | 1 + For consistency with all the other scripts, it could also be just called 'maintscript' instead of 'qemu-server.maintscript'. > 2 files changed, 19 insertions(+) > create mode 100644 debian/postinst > create mode 100644 debian/qemu-server.maintscript > > diff --git a/debian/postinst b/debian/postinst > new file mode 100644 > index 00000000..aff4a27e > --- /dev/null > +++ b/debian/postinst > @@ -0,0 +1,18 @@ > +#!/bin/sh > + > +set -e > + > +#DEBHELPER# > + > +case "$1" in > + configure) > + > + if test -n "$2" && dpkg --compare-versions "$2" 'lt' '9.1.6'; then > + if test -f /etc/modules-load.d/qemu-server.conf.dpkg-bak; then > + printf "Moving qemu-server.conf.dpkg-bak back to qemu-server.conf\n" > + mv /etc/modules-load.d/qemu-server.conf.dpkg-bak /etc/modules-load.d/qemu-server.conf > + fi > + fi > +esac > + > +exit 0 > diff --git a/debian/qemu-server.maintscript b/debian/qemu-server.maintscript > new file mode 100644 > index 00000000..c48d470f > --- /dev/null > +++ b/debian/qemu-server.maintscript > @@ -0,0 +1 @@ > +rm_conffile /etc/modules-load.d/qemu-server.conf 9.1.6~ qemu-server