From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 799899EA0F for <pve-devel@lists.proxmox.com>; Thu, 2 Nov 2023 20:47:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5A08A152F8 for <pve-devel@lists.proxmox.com>; Thu, 2 Nov 2023 20:47:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Thu, 2 Nov 2023 20:47:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1B27343DA4 for <pve-devel@lists.proxmox.com>; Thu, 2 Nov 2023 20:47:06 +0100 (CET) Message-ID: <57c34bc1-8ee9-4cf7-8f3f-eaa5c7607eab@proxmox.com> Date: Thu, 2 Nov 2023 20:47:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20231102150823.46611-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20231102150823.46611-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.119 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment PROLO_LEO1 0.1 Meta Catches all Leo drug variations so far SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] =?utf-8?b?YcO8w7zDtm9lZDogIFtQQVRDSCBkb2NzXSBjb3Jy?= =?utf-8?q?ect_outdated_info_about_gui_header?= X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 02 Nov 2023 19:47:07 -0000 On 02/11/2023 16:08, Dominik Csapak wrote: > the header part of the gui did change, by moving the user name into a > button, which now contains more user specific actions. Update it to be > correct again. > applied, with some language follow-ups, thanks — keeping such things up-to-date is important work! > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> > --- > pve-gui.adoc | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/pve-gui.adoc b/pve-gui.adoc > index 9f63a7e..046fb9f 100644 > --- a/pve-gui.adoc > +++ b/pve-gui.adoc > @@ -101,21 +101,23 @@ search bar nearside you can search for specific objects (VMs, > containers, nodes, ...). This is sometimes faster than selecting an > object in the resource tree. > > -To the right of the search bar we see the identity (login name). The > -gear symbol is a button opening the 'My Settings' dialog. There you > -can customize some client side user interface setting (reset the saved > -login name, reset saved layout). > - > -The rightmost part of the header contains four buttons: > +The right part of the header contains four buttons: > > [horizontal] > -Help :: Opens a new browser window showing the reference documentation. > +Documentation :: Opens a new browser window showing the reference documentation. > > Create VM :: Opens the virtual machine creation wizard. > > Create CT :: Open the container creation wizard. > > -Logout :: Logout, and show the login dialog again. > +Identity Menu :: Displays the identity and contains user specific options. IMO that name is rather odd.. changed to "User Menu" I connected the following paragraph with the above definition-list entry by placing a "+" on the empty line, that way they are separate paragraphs but still indented on the same level, which IMO makes sense for the menu child entries. > + > +The identity menu contains various user specific options, such as the 'My "various user specific options" is a repetition from the list above, sticks especially out because it's already a bit superfluous there too, i.e., what else would the "user menu" contain? ^^ > +Settings' dialog. There you can customize some client side user interface > +setting (reset the saved login name, reset saved layout). I reworded to avoid the parenthesis, but they were mostly pre-exsiting, so just mentioning for the record. > + > +It also contains a shortcut to the 'TFA', 'Language' and 'Color Theme' > +settings, as well as the Logout option. > > > [[gui_my_settings]]