From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id E7AF41FF0C0 for ; Wed, 18 Nov 2026 15:37:28 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id DAAFE21724; Wed, 18 Nov 2026 15:37:25 +0100 (CET) Message-ID: <5785d551-03b4-4161-b92c-87aa498445eb@proxmox.com> Date: Wed, 18 Nov 2026 15:36:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: applied: [PATCH-SERIES many v7 00/32] migration: strict config check for intra-cluster migration To: Thomas Lamprecht , pve-devel@lists.proxmox.com References: <20261112115001.107306-1-f.ebner@proxmox.com> <179501161074.1321919.11775152234630231861.b4-ty@b4> Content-Language: en-US From: Fiona Ebner In-Reply-To: <179501161074.1321919.11775152234630231861.b4-ty@b4> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795012601515 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.247 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YTNGTVJOQTHYR4KW2WG55YHFBMI2YLFJ X-Message-ID-Hash: YTNGTVJOQTHYR4KW2WG55YHFBMI2YLFJ X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 18.11.26 um 3:25 PM schrieb Thomas Lamprecht: > On Thu, 12 Nov 2026 12:48:32 +0100, Fiona Ebner wrote: > I adapted a few things on/after applying, mainly: > > - guest-common: abort the migration if a stop request arrives while the > tunnel of the config check gets finished. That error was only logged > as warning before, so the migration continued until the task got > killed, without any cleanup. Also log when the check is skipped > because the local node is too old, like for the other skip reasons. > - qemu-server: moved the test mocks for the check tunnel from patch 11 > into patch 10, so that each commit passes the migration tests with the > new guest-common, as Michael noted. Patch 11 is now titled "migration: > add 'skip-config-check' property". > - match the VMID of the new mtunnel 'config' command with [0-9] instead > of \d, and name that command correctly in the subject of patch 09. > - container: the 'skip-config-check' description now says that options > can get dropped or ignored, like the UI warning does. > - ha-manager: dropped the unused $ns of handle_resource_motion_command(), > include the command in the error for a JSON 'migrate' command without > sid or node, and added the semicolon Michael noted. > - reworded some comments and commit messages, for example to name > prepare_local_cluster_checks() instead of check_config_on_target(), > and fixed typos in the README of the new HA test. > > Patch 15 got skipped, as pve-container already build-depends on > libpve-common-perl 9.2.10 now. > > On top, I added migration tests for a target that rejects the config, > for the skip flag and for a target that is too old for the check. Thank you for the improvements!