From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DC5CB1FF16B for ; Tue, 29 Jul 2025 18:52:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BC95218A6C; Tue, 29 Jul 2025 18:54:12 +0200 (CEST) Message-ID: <5670504d-3221-4e6b-9e5d-534843b4911e@proxmox.com> Date: Tue, 29 Jul 2025 18:54:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Lukas Wagner , Proxmox Backup Server development discussion References: <20250728124006.868999-1-c.ebner@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753808040359 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/7] remove objects from s3 backend on datastore destroy X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 7/29/25 3:53 PM, Lukas Wagner wrote: > On Mon Jul 28, 2025 at 2:39 PM CEST, Christian Ebner wrote: >> This patch series makes sure the datastore contents are also removed >> from the s3 backend if the datastore is destroyed with the remove all >> data flag being set. >> >> The first 6 patches fix clippy warnings and refactor the s3 client from >> datastore config generation into a dedicated helper, since the last >> patch requires that as well and this would be the third ocurence thereof. >> >> The last patch finally does the object store cleanup if the datastore is >> backed by s3 and the data should be removed. This simply clears all >> contents starting with the store prefix from the bucket. >> > > Looks good to me! Also quickly tested this with my minio server. > Also made sure that it does not delete anything else in the bucket. > > Only thing that maybe could be improved is the wording on the checkbox > in the "Delete datastore" confirmation dialog. Right now it is: > > [ ] Destroy all data (dangerous!) > > Maybe something like this could be more clear: > > [ ] Remove data from S3 bucket and local cache (dangerous!) > > But this could also done as a followup, since this is just cosmetic. Sent the request followup which can be found at: https://lore.proxmox.com/pbs-devel/20250729165249.855831-1-c.ebner@proxmox.com/T/ _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel