From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id DEF029BC33
for <pve-devel@lists.proxmox.com>; Fri, 20 Oct 2023 15:28:08 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id B986E34B71
for <pve-devel@lists.proxmox.com>; Fri, 20 Oct 2023 15:27:38 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Fri, 20 Oct 2023 15:27:37 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6803543687;
Fri, 20 Oct 2023 15:27:37 +0200 (CEST)
Message-ID: <54d4c5b7-ebd9-4e0d-b789-1669455b059e@proxmox.com>
Date: Fri, 20 Oct 2023 15:27:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
References: <20230705111257.759836-1-c.heiss@proxmox.com>
<20230705111257.759836-5-c.heiss@proxmox.com>
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20230705111257.759836-5-c.heiss@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.012 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager v2 4/5] ui: GuestStatusView: show
privileged status as new row
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 20 Oct 2023 13:28:08 -0000
one small comment inline
On 7/5/23 13:12, Christoph Heiss wrote:
> As that info is not available through the store (which stores the
> status), it must be fetched separately.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> www/manager6/panel/GuestStatusView.js | 32 +++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/www/manager6/panel/GuestStatusView.js b/www/manager6/panel/GuestStatusView.js
> index 8db1f492c..ca2f03453 100644
> --- a/www/manager6/panel/GuestStatusView.js
> +++ b/www/manager6/panel/GuestStatusView.js
> @@ -11,6 +11,29 @@ Ext.define('PVE.panel.GuestStatusView', {
> };
> },
>
> + controller: {
> + xclass: 'Ext.app.ViewController',
> +
> + init: view => {
while this works, it's a rather unusual use for us
normally we use the standard 'function(view) {}' syntax
the advantage of that is that the 'this' object then
is the controller
if someone wants to use the controller in the future and starts
using 'this' it won't work with the arrow syntax (it will be undefined)
> + if (view.pveSelNode.data.type !== 'lxc') {
> + return;
> + }
> +
> + const nodename = view.pveSelNode.data.node;
> + const vmid = view.pveSelNode.data.vmid;
> +
> + Proxmox.Utils.API2Request({
> + url: `/api2/extjs/nodes/${nodename}/lxc/${vmid}/config`,
> + waitMsgTargetView: view,
> + method: 'GET',
> + success: ({ result }) => {
> + view.down('#unprivileged').updateValue(
> + Proxmox.Utils.format_boolean(result.data.unprivileged));
> + },
> + });
> + },
> + },
> +
> layout: {
> type: 'vbox',
> align: 'stretch',
> @@ -58,6 +81,15 @@ Ext.define('PVE.panel.GuestStatusView', {
> },
> printBar: false,
> },
> + {
> + itemId: 'unprivileged',
> + iconCls: 'fa fa-lock fa-fw',
> + title: gettext('Unprivileged'),
> + printBar: false,
> + cbind: {
> + hidden: '{isQemu}',
> + },
> + },
> {
> xtype: 'box',
> height: 15,