From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id BF76372B7C
for <pve-devel@lists.proxmox.com>; Wed, 26 May 2021 11:08:55 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id B341AF035
for <pve-devel@lists.proxmox.com>; Wed, 26 May 2021 11:08:55 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 341EAF027
for <pve-devel@lists.proxmox.com>; Wed, 26 May 2021 11:08:55 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0182346666
for <pve-devel@lists.proxmox.com>; Wed, 26 May 2021 11:08:55 +0200 (CEST)
Message-ID: <543e6e10-4f09-0cc6-3b10-3824f1cc56b9@proxmox.com>
Date: Wed, 26 May 2021 11:08:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101
Thunderbird/89.0
Content-Language: en-US
To: Oguz Bektas <o.bektas@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20210525131559.1007131-1-o.bektas@proxmox.com>
<00ebc5fa-145a-10ea-62e1-812d1ada7471@proxmox.com>
<20210526084816.GA14375@gaia.proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20210526084816.GA14375@gaia.proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.010 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.001 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH container] setup: make randomize_crontab a
state subroutine
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 26 May 2021 09:08:55 -0000
On 26.05.21 10:48, Oguz Bektas wrote:
> On Tue, May 25, 2021 at 03:26:12PM +0200, Thomas Lamprecht wrote:
>> On 25.05.21 15:15, Oguz Bektas wrote:
>>> for consistency in post_create_hook. still works as expected
>>>
>>
>> what's the reason/benefit again?
>
> it looked a bit ugly otherwise with all the other ones being state subs,
> so it's just a style change in the end. anything against this?
no this is not just a style change! You change a method from being a *private*
helper to be a *public* method, and not only that, as this is a plugin "class"
which other modules base off you added that method to the API of the plugin
interface and that without any actual reason!
Rather than asking other to provide reason against changes ask yourself first
what the actual implications are and if there's any actual advantage, which
"looks prettier in my personal perception" seldom counts towards too...
>>
>>> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
>>> ---
>>> src/PVE/LXC/Setup/Base.pm | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm
>>> index d73335b..be41874 100644
>>> --- a/src/PVE/LXC/Setup/Base.pm
>>> +++ b/src/PVE/LXC/Setup/Base.pm
>>> @@ -422,7 +422,7 @@ sub set_user_authorized_ssh_keys {
>>> $self->ct_modify_file("$home/.ssh/authorized_keys", $ssh_keys, perms => 0700);
>>> }
>>>
>>> -my $randomize_crontab = sub {
>>> +sub randomize_crontab {
>>> my ($self, $conf) = @_;
>>>
>>> my @files;
>>> @@ -450,7 +450,7 @@ my $randomize_crontab = sub {
>>> }
>>> $self->ct_file_set_contents($filename, $new);
>>> }
>>> -};
>>> +}
>>>
>>> sub set_timezone {
>>> my ($self, $conf) = @_;
>>> @@ -493,7 +493,7 @@ sub post_create_hook {
>>>
>>> $self->template_fixup($conf);
>>>
>>> - &$randomize_crontab($self, $conf);
>>> + $self->randomize_crontab($conf);
>>>
>>> $self->set_user_password($conf, 'root', $root_password);
>>> $self->set_user_authorized_ssh_keys($conf, 'root', $ssh_keys) if $ssh_keys;
>>>
>>