From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id D1C211FF185
	for <inbox@lore.proxmox.com>; Mon, 21 Jul 2025 13:41:58 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 92181C169;
	Mon, 21 Jul 2025 13:43:09 +0200 (CEST)
Message-ID: <541a134f-9a3a-499a-bf20-dd0257bf07b7@proxmox.com>
Date: Mon, 21 Jul 2025 13:43:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Aaron Lauterer <a.lauterer@proxmox.com>
References: <20250715143218.1548306-1-a.lauterer@proxmox.com>
 <20250715143218.1548306-14-a.lauterer@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20250715143218.1548306-14-a.lauterer@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1753098178476
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.022 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH widget-toolkit v3 2/2] rrdchart: use
 reference for undo button
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 7/15/25 16:31, Aaron Lauterer wrote:
> This makes targeting the undo button more stable in situations where it
> might not be the 0 indexed item in the tools.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>   src/panel/RRDChart.js | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/panel/RRDChart.js b/src/panel/RRDChart.js
> index 3b41ae6..f9a9b33 100644
> --- a/src/panel/RRDChart.js
> +++ b/src/panel/RRDChart.js
> @@ -152,7 +152,7 @@ Ext.define('Proxmox.widget.RRDChart', {
>                   return;
>               }
>               // if the undo button is disabled, disable our tool
> -            let ourUndoZoomButton = chart.header.tools[0];
> +            let ourUndoZoomButton = chart.lookupReference('undoButton');
>               let undoButton = chart.interactions[0].getUndoButton();
>               ourUndoZoomButton.setDisabled(undoButton.isDisabled());
>           },
> @@ -269,6 +269,7 @@ Ext.define('Proxmox.widget.RRDChart', {
>               me.addTool({
>                   type: 'minus',
>                   disabled: true,
> +                reference: 'undoButton',
>                   tooltip: gettext('Undo Zoom'),
>                   handler: function () {
>                       let undoButton = me.interactions[0].getUndoButton();



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel