From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 47C001FF13F for ; Thu, 09 Apr 2026 14:30:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 16DBF3E9B; Thu, 9 Apr 2026 14:31:17 +0200 (CEST) Date: Thu, 9 Apr 2026 14:30:41 +0200 From: Arthur Bied-Charreton To: Lukas Wagner Subject: Re: [PATCH proxmox v2 02/16] notify: smtp: Introduce state management Message-ID: <53pudxn6nglyboxg5yn3dzi6kztyaadhyi6gu6wfvir6odti47@woeijtzsnxx3> References: <20260325131444.366808-1-a.bied-charreton@proxmox.com> <20260325131444.366808-3-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775737774377 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.795 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4U6TGPS3TE6CACGFQUFJPUBWBHBJPNPH X-Message-ID-Hash: 4U6TGPS3TE6CACGFQUFJPUBWBHBJPNPH X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Apr 09, 2026 at 11:51:43AM +0200, Lukas Wagner wrote: [...] > > +impl State { > > + /// Load the state for the endpoint identified by `endpoint_name`, instantiating a default object > > + /// if yes state exists. [...] > > + > > + /// Persist the state for the endpoint identified by `endpoint_name`. > > + /// > > + /// # Errors > > + /// An [`Error`] is returned if serialization of the state object, or the final write, fail. [...] > > + pub(crate) fn save>( > > + > > + /// Delete the state for the endpoint identitied by `endpoint_name`. > > + /// > > + /// # Errors > > + /// An [`Error`] is returned if the state file cannot be deleted. [...] > > + pub(crate) fn delete>(path: P) { [...] Also just noticed while addressing the feedback that these doc comments are incorrect, since the methods now take the whole paths directly, will update those as well