From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id C20011FF0B4 for ; Wed, 09 Sep 2026 10:13:55 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 224AA21580; Wed, 09 Sep 2026 10:13:53 +0200 (CEST) Message-ID: <53fa0049-2e64-49a0-822a-da52f3589d45@proxmox.com> Date: Wed, 9 Sep 2026 10:13:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-network] sdn: zones: look the underlay interface up correctly To: pve-devel@lists.proxmox.com References: <20260909075328.726069-1-h.laimer@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20260909075328.726069-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.845 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BKKKVXRUU5X7GWY35TWWJLAAZEOVAG2H X-Message-ID-Hash: BKKKVXRUU5X7GWY35TWWJLAAZEOVAG2H X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 9/9/26 9:53 AM, Hannes Laimer wrote: > The interfaces reader returns the table under a key, and the vxlan and > evpn zones looked their underlay interface up at the top level of the > reader's result, so the MTU they derive from it never applied and every > vnet bridge of theirs got the default or the zone's own MTU. Ironically we independently discovered this yesterday [1], but we're a bit afraid of breaking setups that implicitly rely on that behavior. [1] https://bugzilla.proxmox.com/show_bug.cgi?id=8018 > Signed-off-by: Hannes Laimer > --- > the alternative would be already passing `->{ifaces}`, but we'd lose the > options like that. i think this is better. > > src/PVE/Network/SDN/Zones/EvpnPlugin.pm | 3 ++- > src/PVE/Network/SDN/Zones/VxlanPlugin.pm | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/Network/SDN/Zones/EvpnPlugin.pm b/src/PVE/Network/SDN/Zones/EvpnPlugin.pm > index 0e79707..f89decf 100644 > --- a/src/PVE/Network/SDN/Zones/EvpnPlugin.pm > +++ b/src/PVE/Network/SDN/Zones/EvpnPlugin.pm > @@ -214,7 +214,8 @@ sub generate_sdn_config { > > my $mtu = 1450; > if ($iface) { > - $mtu = $interfaces_config->{$iface}->{mtu} - 50 if $interfaces_config->{$iface}->{mtu}; > + $mtu = $interfaces_config->{ifaces}->{$iface}->{mtu} - 50 > + if $interfaces_config->{ifaces}->{$iface}->{mtu}; > } > $mtu = $plugin_config->{mtu} if $plugin_config->{mtu}; > > diff --git a/src/PVE/Network/SDN/Zones/VxlanPlugin.pm b/src/PVE/Network/SDN/Zones/VxlanPlugin.pm > index a408261..b4e743e 100644 > --- a/src/PVE/Network/SDN/Zones/VxlanPlugin.pm > +++ b/src/PVE/Network/SDN/Zones/VxlanPlugin.pm > @@ -119,7 +119,8 @@ sub generate_sdn_config { > > my $mtu = 1450; > if ($iface) { > - $mtu = $interfaces_config->{$iface}->{mtu} - 50 if $interfaces_config->{$iface}->{mtu}; > + $mtu = $interfaces_config->{ifaces}->{$iface}->{mtu} - 50 > + if $interfaces_config->{ifaces}->{$iface}->{mtu}; > } > $mtu = $plugin_config->{mtu} if $plugin_config->{mtu}; >