From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <aderumier@odiso.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3FA6261AA2 for <pve-devel@lists.proxmox.com>; Mon, 7 Sep 2020 15:48:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2CECBB6A5 for <pve-devel@lists.proxmox.com>; Mon, 7 Sep 2020 15:47:52 +0200 (CEST) Received: from mailpro.odiso.net (mailpro.odiso.net [89.248.211.110]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3BA05B699 for <pve-devel@lists.proxmox.com>; Mon, 7 Sep 2020 15:47:47 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mailpro.odiso.net (Postfix) with ESMTP id 01C6C18D9818; Mon, 7 Sep 2020 15:47:47 +0200 (CEST) Received: from mailpro.odiso.net ([127.0.0.1]) by localhost (mailpro.odiso.net [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id UuP-JX0pv0P5; Mon, 7 Sep 2020 15:47:46 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mailpro.odiso.net (Postfix) with ESMTP id D9C3D18D9819; Mon, 7 Sep 2020 15:47:46 +0200 (CEST) X-Virus-Scanned: amavisd-new at mailpro.odiso.com Received: from mailpro.odiso.net ([127.0.0.1]) by localhost (mailpro.odiso.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Y9WcXvrMds9R; Mon, 7 Sep 2020 15:47:46 +0200 (CEST) Received: from mailpro.odiso.net (mailpro.odiso.net [10.1.31.111]) by mailpro.odiso.net (Postfix) with ESMTP id C24A418D9818; Mon, 7 Sep 2020 15:47:46 +0200 (CEST) Date: Mon, 7 Sep 2020 15:47:46 +0200 (CEST) From: Alexandre DERUMIER <aderumier@odiso.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Message-ID: <532694180.424495.1599486466603.JavaMail.zimbra@odiso.com> In-Reply-To: <fffdf263-4b5b-b02e-a8da-7b123075e37a@proxmox.com> References: <CAMnnoUJMy_HFbYmceV5s+kN8j=3_0K0SPqn9NramQxnePvAJyw.ref@mail.gmail.com> <CAMnnoUJMy_HFbYmceV5s+kN8j=3_0K0SPqn9NramQxnePvAJyw@mail.gmail.com> <fffdf263-4b5b-b02e-a8da-7b123075e37a@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: Zimbra 8.8.12_GA_3866 (ZimbraWebClient - GC83 (Linux)/8.8.12_GA_3844) Thread-Topic: Telegraf added in-built Proxmox support - thoughts versus our external metric support? Thread-Index: TbRhE1HtklTGOb/g5sYe3VIn20H0Dw== X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] Telegraf added in-built Proxmox support - thoughts versus our external metric support? X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 07 Sep 2020 13:48:22 -0000 Hi, >>Anyway, I do not think that we should drop our direct plugins (yet), some >>people like me, are happy feeding directly to InfluxDB without anything >>in-between. me too ;) I'm not sure, but I think than we send more metrics to influxdb, than we st= ream through the cluster.=20 and the plugin does seem to use /cluster/resources api, but seem to do 1 ap= i request by vm. (So with a lot of vm, maybe it'll flood the api) ----- Mail original ----- De: "Thomas Lamprecht" <t.lamprecht@proxmox.com> =C3=80: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>, = "Victor Hooi" <victorhooi@yahoo.com> Envoy=C3=A9: Lundi 7 Septembre 2020 08:57:31 Objet: Re: [pve-devel] Telegraf added in-built Proxmox support - thoughts v= ersus our external metric support? Hi,=20 On 07.09.20 03:42, Victor Hooi wrote:=20 > I know that Proxmox has it's own inbuilt InfluxDB client:=20 >=20 > https://pve.proxmox.com/wiki/External_Metric_Server=20 >=20 > However, Telegraf recently added first-party support for Proxmox:=20 >=20 > https://github.com/influxdata/telegraf/tree/master/plugins/inputs/proxmox= =20 great!=20 > Telegraf lets you output to InfluxDB, Graphite, Prometheus, as well as a= =20 > bunch of others (Telegraf in-built output clients=20 > <https://github.com/influxdata/telegraf/tree/master/plugins/outputs>)=20 >=20 > What do you think of using the above and contributing to that, instead of= =20 > maintaining our own Proxmox InfluxDB support?=20 >=20 > Or are there advantages to maintaining our own code here?=20 The pvestatd, which queries statistics periodically, does also the sending= =20 of said statistics without extra overhead. API request may get, at least=20 partially, up to date information with an extra overhead, e.g., if storage= =20 stats are to be queried too. That could be addressed by providing a pvestat= d=20 fed cache in /run (fast memory tmpfs) or so and provide access to that over= =20 the API.=20 Anyway, I do not think that we should drop our direct plugins (yet), some= =20 people like me, are happy feeding directly to InfluxDB without anything=20 in-between.=20 But, we definitively want to mention this in the documentation and see how= =20 we can improve integration.=20 cheers,=20 Thomas=20 _______________________________________________=20 pve-devel mailing list=20 pve-devel@lists.proxmox.com=20 https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel=20