From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 37D4563D7D for <pve-devel@lists.proxmox.com>; Wed, 25 Nov 2020 15:00:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2B02A1AEA3 for <pve-devel@lists.proxmox.com>; Wed, 25 Nov 2020 15:00:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 628A51AE98 for <pve-devel@lists.proxmox.com>; Wed, 25 Nov 2020 15:00:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2599D4405B; Wed, 25 Nov 2020 15:00:43 +0100 (CET) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Alexandre Derumier <aderumier@odiso.com> References: <20201125090139.3553272-1-aderumier@odiso.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <5186621e-3a38-b7c8-8b1b-3e22a5429d71@proxmox.com> Date: Wed, 25 Nov 2020 15:00:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201125090139.3553272-1-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.079 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [plugin.pm, vlanplugin.pm, controllers.pm, qinqplugin.pm, proxmox.com, sdn.pm, bgpplugin.pm, evpnplugin.pm, simpleplugin.pm, vxlanplugin.pm, faucetplugin.pm, zones.pm] Subject: [pve-devel] applied-series: [PATCH V2 pve-network 0/4] add ebgp-evpn support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 25 Nov 2020 14:00:44 -0000 On 25.11.20 10:01, Alexandre Derumier wrote: > This add support for a new controller plugin "bgp", > to manage specific bgp section by host. > This is allowing ebgp >=20 > (I'll send doc soon) >=20 > Also some fixes on pending parser >=20 > Changelog V2: >=20 > - fix some bug in bgp plugin >=20 > Alexandre Derumier (4): > controllers: improve bgp-evpn > zones: evpn : add support for loopback > update test documentation > sdn: fix : pending parser >=20 > PVE/API2/Network/SDN/Controllers.pm | 1 + > PVE/API2/Network/SDN/Zones.pm | 12 +- > PVE/Network/SDN.pm | 45 +++++- > PVE/Network/SDN/Controllers.pm | 12 +- > PVE/Network/SDN/Controllers/BgpPlugin.pm | 153 ++++++++++++++++++++= > PVE/Network/SDN/Controllers/EvpnPlugin.pm | 122 ++++++++++------ > PVE/Network/SDN/Controllers/FaucetPlugin.pm | 4 +- > PVE/Network/SDN/Controllers/Makefile | 2 +- > PVE/Network/SDN/Controllers/Plugin.pm | 9 +- > PVE/Network/SDN/Zones.pm | 2 +- > PVE/Network/SDN/Zones/EvpnPlugin.pm | 12 +- > PVE/Network/SDN/Zones/Plugin.pm | 39 ++--- > PVE/Network/SDN/Zones/QinQPlugin.pm | 2 +- > PVE/Network/SDN/Zones/SimplePlugin.pm | 2 +- > PVE/Network/SDN/Zones/VlanPlugin.pm | 2 +- > PVE/Network/SDN/Zones/VxlanPlugin.pm | 2 +- > test/documentation.txt | 14 +- > 17 files changed, 336 insertions(+), 99 deletions(-) > create mode 100644 PVE/Network/SDN/Controllers/BgpPlugin.pm >=20 applied, thanks! FYI, I tried to create a somewhat sensible perlcritic config which could = be useful. It shows a few conditionally declared variables (`my $foo =3D 1 if $bar`)= in pve-network, among other things: https://pve.proxmox.com/wiki/Perl_Style_Guide#Basic_Linting_with_perlcrit= ic Maybe it help you (and naturally all others) to avoid a few such possible= bugs. Note, it is not a complete check, e.g., it does not cares a bout a few th= ings (missing variables or so).=20